Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

depth exact #170

Merged
merged 4 commits into from
Jul 31, 2023
Merged

depth exact #170

merged 4 commits into from
Jul 31, 2023

Conversation

jordens
Copy link
Member

@jordens jordens commented Jul 31, 2023 •
edited
Loading

  • fix option depth
  • exact depth

close #169

jordens added 2 commits July 31, 2023 21:36
@jordens
fix option depth
30a51d3
@jordens
exact depth
c2b42f0 
compute exact struct depth and use for exact iterator
this removes a slew of unwraps and gives the trait parameter
a meaning
@jordens jordens changed the base branch from main to depth July 31, 2023 19:38
@jordens jordens requested a review from ryan-summers July 31, 2023 19:51
@jordens jordens mentioned this pull request Jul 31, 2023
Merged
@jordens jordens merged commit 6802cae into depth Jul 31, 2023
@jordens jordens deleted the depth-exact branch July 31, 2023 20:53
@jordens jordens linked an issue Aug 1, 2023 that may be closed by this pull request
Fix Option depth #169
Closed
@jordens jordens mentioned this pull request Aug 1, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ryan-summers ryan-summers Awaiting requested review from ryan-summers

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix Option depth
1 participant
@jordens