Re-authenticate users if the OIDC session cookie can not be read #46822
+40
−11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gastaldi
reviewed
Mar 14, 2025
| // Make this error message visible in the dev mode | ||
| return Uni.createFrom().failure(new AuthenticationFailedException(error)); | ||
| } catch (NumberFormatException ex) { | ||
| final String error = "Access token expires_in property in the session cookie must be a number"; |
There was a problem hiding this comment.
It would be nice if we had the value that was found, for debugging purposes
Suggested change
| final String error = "Access token expires_in property in the session cookie must be a number"; | |
| final String error = "Access token expires_in property in the session cookie must be a number, found %s"; |
There was a problem hiding this comment.
@gastaldi Sure, took me a little while to experiment with getting to that value from different branches, so I wrapped the actual parsing call in a function to make it easier, hope it looks better
gastaldi
approved these changes
Mar 14, 2025
This comment has been minimized.
This comment has been minimized.
sberyozkin
force-pushed
the
reauth_when_session_cookie_can_not_be_read
branch
from
d5bc3a5 to
3b248a5
Compare
Status for workflow
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #46765.
The internal session cookie format changed in 3.18, which, given it is not part of the API, should not have caused any issues. However, in advanced OIDC applications, what happens, as explained by @sschellh, is that there could be a large number of currently logged in users possibly in different regions, which have not had time to logout before the new Quarkus release is deployed. thus keeping the existing session cookies.
For example, a user logged in the morning, the session is active for 8 hours, new Quarkus is deployed at lunch time, and the user can not access the application after lunch.
In such cases, if the internal session format changes, currently, Quarkus, after failing to parse the cookie content, stops users in their tracks with
401which is not a good user experience.Instead, Quarkus should remove the session cookie it can not parse and request re-authentication - the user may not even notice if the OIDC provider's own session cookies still valid.
This is what this simple PR does - deletes the session cookie (this is already done on main and tested) but instead of terminating the flow with 401, it forces the re-authentication with 302.