Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make ResponseBuilderImpl more ipv6 aware #46632

Merged
merged 1 commit into from
Mar 10, 2025
Merged

Conversation

shawkins
Copy link
Contributor

@shawkins shawkins commented Mar 5, 2025

Adds a check for ipv6 style host addresses.

The only thing that still looks odd is the content location header value is a URI - should it be a String instead?

closes: #46430

Copy link
Contributor

@geoand geoand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@geoand geoand added the triage/waiting-for-ci Ready to merge when CI successfully finishes label Mar 6, 2025

This comment has been minimized.

@gsmet
Copy link
Member

gsmet commented Mar 10, 2025

I force pushed a fix for the formatting issue.

Copy link

quarkus-bot bot commented Mar 10, 2025

Status for workflow Quarkus CI

This is the status report for running Quarkus CI on commit 1e58884.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

You can consult the Develocity build scans.


Flaky tests - Develocity

⚙️ JVM Tests - JDK 17

📦 extensions/panache/hibernate-reactive-rest-data-panache/deployment

io.quarkus.hibernate.reactive.rest.data.panache.deployment.repository.PanacheRepositoryResourcePutMethodTest.shouldUpdateSimpleObject - History

  • 1 expectation failed. JSON path name doesn't match. Expected: is "first-test" Actual: first - java.lang.AssertionError
java.lang.AssertionError: 
1 expectation failed.
JSON path name doesn't match.
Expected: is "first-test"
  Actual: first

	at java.base/java.lang.reflect.Constructor.newInstanceWithCaller(Constructor.java:500)
	at java.base/java.lang.reflect.Constructor.newInstance(Constructor.java:481)

⚙️ JVM Tests - JDK 21

📦 extensions/smallrye-reactive-messaging-kafka/deployment

io.quarkus.smallrye.reactivemessaging.kafka.deployment.testing.KafkaDevServicesContinuousTestingTestCase.testContinuousTestingScenario2 - History

  • io.quarkus.builder.BuildException: Build failure: Build failed due to errors [error]: Build step io.quarkus.apicurio.registry.devservice.DevServicesApicurioRegistryProcessor\#startApicurioRegistryDevService threw an exception: java.lang.RuntimeException: org.testcontainers.containers.ContainerLaunchException: Container startup failed for image quay.io/apicurio/apicurio-registry-mem:2.4.2.Final at io.quarkus.apicurio.registry.devservice.DevServicesApicurioRegistryProcessor.startApicurioRegistryDevService(DevServicesApicurioRegistryProcessor.java:90) at java.base/java.lang.invoke.MethodHandle.invokeWithArguments(MethodHandle.java:733) at io.quarkus.deployment.ExtensionLoader$3.execute(ExtensionLoader.java:856) - java.lang.RuntimeException
java.lang.RuntimeException: 
io.quarkus.builder.BuildException: Build failure: Build failed due to errors
	[error]: Build step io.quarkus.apicurio.registry.devservice.DevServicesApicurioRegistryProcessor#startApicurioRegistryDevService threw an exception: java.lang.RuntimeException: org.testcontainers.containers.ContainerLaunchException: Container startup failed for image quay.io/apicurio/apicurio-registry-mem:2.4.2.Final
	at io.quarkus.apicurio.registry.devservice.DevServicesApicurioRegistryProcessor.startApicurioRegistryDevService(DevServicesApicurioRegistryProcessor.java:90)
	at java.base/java.lang.invoke.MethodHandle.invokeWithArguments(MethodHandle.java:733)
	at io.quarkus.deployment.ExtensionLoader$3.execute(ExtensionLoader.java:856)
	at io.quarkus.builder.BuildContext.run(BuildContext.java:255)
	at org.jboss.threads.ContextHandler$1.runWith(ContextHandler.java:18)

@geoand geoand merged commit 10de80c into quarkusio:main Mar 10, 2025
53 checks passed
@quarkus-bot quarkus-bot bot removed the triage/waiting-for-ci Ready to merge when CI successfully finishes label Mar 10, 2025
@quarkus-bot quarkus-bot bot added this to the 3.21 - main milestone Mar 10, 2025
@gsmet gsmet modified the milestones: 3.21 - main, 3.19.3 Mar 11, 2025
benkard pushed a commit to benkard/quarkus-googlecloud-jsonlogging that referenced this pull request Mar 14, 2025
…us-googlecloud-jsonlogging!27)

This MR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
| [io.quarkus:quarkus-extension-processor](https://github.com/quarkusio/quarkus) |  | patch | `3.19.2` -> `3.19.3` |
| [io.quarkus:quarkus-extension-maven-plugin](https://github.com/quarkusio/quarkus) | build | patch | `3.19.2` -> `3.19.3` |
| [io.quarkus:quarkus-bom](https://github.com/quarkusio/quarkus) | import | patch | `3.19.2` -> `3.19.3` |
| [io.quarkus:quarkus-maven-plugin](https://github.com/quarkusio/quarkus) | build | patch | `3.19.2` -> `3.19.3` |

---

### Release Notes

<details>
<summary>quarkusio/quarkus</summary>

### [`v3.19.3`](https://github.com/quarkusio/quarkus/releases/tag/3.19.3)

[Compare Source](quarkusio/quarkus@3.19.2...3.19.3)

##### Complete changelog

-   [#&#8203;45112](quarkusio/quarkus#45112) - Exception about missing maven classes when opening the dev-ui (gradle based project)
-   [#&#8203;46430](quarkusio/quarkus#46430) - ResponseBuilderImpl NumberFormatException with IPv6
-   [#&#8203;46459](quarkusio/quarkus#46459) - Upgrading from 3.18.2 to 3.18.3 Results in OutOfMemoryError when using `@QuarkusTest` with Quarkus Junit 5
-   [#&#8203;46527](quarkusio/quarkus#46527) - Broken archive in vaadin-webcomponent dependency
-   [#&#8203;46566](quarkusio/quarkus#46566) - Issuer-based OIDC tenant resolver should check `quarkus.oidc.token.required-claims`
-   [#&#8203;46615](quarkusio/quarkus#46615) - OIDC client token requests retry not working
-   [#&#8203;46621](quarkusio/quarkus#46621) - Bump testcontainers.version from 1.20.5 to 1.20.6
-   [#&#8203;46624](quarkusio/quarkus#46624) - Devui Database View can not find tables in different schemas
-   [#&#8203;46632](quarkusio/quarkus#46632) - Make ResponseBuilderImpl more ipv6 aware
-   [#&#8203;46634](quarkusio/quarkus#46634) - Check required claims in OIDC issuer-based resolver
-   [#&#8203;46635](quarkusio/quarkus#46635) - Update some dev-ui libs versions
-   [#&#8203;46638](quarkusio/quarkus#46638) - Bump Keycloak version to 26.1.3
-   [#&#8203;46640](quarkusio/quarkus#46640) - Using SocketException in all of the OIDC retry code
-   [#&#8203;46651](quarkusio/quarkus#46651) - Fix non-public schema in DB Viewer for Dev UI
-   [#&#8203;46653](quarkusio/quarkus#46653) - Add -e to quarkus update commands and improve display
-   [#&#8203;46655](quarkusio/quarkus#46655) - JSON-B link
-   [#&#8203;46659](quarkusio/quarkus#46659) - Correct link to JSON-B API
-   [#&#8203;46660](quarkusio/quarkus#46660) - Correct summary text of config-yaml.adoc
-   [#&#8203;46661](quarkusio/quarkus#46661) - Correct summary text of spring-boot-properties.adoc
-   [#&#8203;46664](quarkusio/quarkus#46664) - ArC: fix disposer resolution in case the disposed parameter declares no qualifiers
-   [#&#8203;46680](quarkusio/quarkus#46680) - Fix gradle devui NoClassDefFound
-   [#&#8203;46684](quarkusio/quarkus#46684) - Revert "Execute simple JUnit tests and `@QuarkusComponentTest` first"
-   [#&#8203;46685](quarkusio/quarkus#46685) - Micrometer docs moved - fix links
-   [#&#8203;46695](quarkusio/quarkus#46695) - Introduce `server.port` tag into `http.server.active.requests` metric
-   [#&#8203;46700](quarkusio/quarkus#46700) - Exclude `.github/project.yml` from triggering workflows on push event
-   [#&#8203;46706](quarkusio/quarkus#46706) - Fix wording in quarkus-rest jsonview support
-   [#&#8203;46709](quarkusio/quarkus#46709) - Fix true-false typo
-   [#&#8203;46712](quarkusio/quarkus#46712) - Bump resteasy.version from 6.2.11.Final to 6.2.12.Final
-   [#&#8203;46713](quarkusio/quarkus#46713) - Bump hibernate-orm.version from 6.6.9.Final to 6.6.10.Final
-   [#&#8203;46714](quarkusio/quarkus#46714) - Bump io.micrometer:micrometer-bom from 1.14.4 to 1.14.5

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 **Automerge**: Enabled.

♻ **Rebasing**: Whenever MR is behind base branch, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this MR and you won't be reminded about these updates again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this MR, check this box

---

This MR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNC4yNC4wIiwidXBkYXRlZEluVmVyIjoiMzQuMjQuMCJ9-->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ResponseBuilderImpl NumberFormatException with IPv6
3 participants