Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Docs: Update Deploying on OpenShift guide to add RHBQ content #46604

Merged
merged 1 commit into from
Mar 13, 2025
Merged

Docs: Update Deploying on OpenShift guide to add RHBQ content #46604

merged 1 commit into from
Mar 13, 2025
+189 −134

Conversation

sheilamjones
Copy link
Contributor

This PR covers the following updates:

  • Update the upstream Deploying on OpenShift guide to incorporate downstream content
  • Editing review
  • Conditionalize content not relevant for downstream

@sheilamjones sheilamjones marked this pull request as draft March 3, 2025 22:49
@quarkus-bot quarkus-bot bot added area/docstyle issues related for manual docstyle review area/documentation labels Mar 3, 2025
@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 3, 2025 •
edited
Loading

🙈 The PR is closed and the preview is expired.

@sheilamjones sheilamjones force-pushed the QDOCS-1101-restructure-original-guide branch from a0e978f to 02eb8ad Compare March 4, 2025 08:53
@sheilamjones sheilamjones requested a review from iocanel March 4, 2025 13:21
@sheilamjones
Copy link
Contributor Author

Hi @iocanel,
Per discussion on Slack, would it be possible to get your review of this PR, which contains a restructure of the original upstream guide to include the downstream sections as well as links to the new deployment option procedures.
Many thanks
Sheila

@sheilamjones sheilamjones marked this pull request as ready for review March 4, 2025 22:43
@MichalMaler
Copy link
Contributor

Did a downstreaming test and all looks good:
https://gitlab.cee.redhat.com/quarkus-documentation/quarkus/-/jobs/32143400
Changes are visible in the resulting MR.

What is the milestone for this content? 3.20?

@sheilamjones sheilamjones force-pushed the QDOCS-1101-restructure-original-guide branch from 02eb8ad to fca4b95 Compare March 11, 2025 00:03
@quarkus-bot quarkus-bot
Copy link

quarkus-bot bot commented Mar 11, 2025

Status for workflow Quarkus Documentation CI

This is the status report for running Quarkus Documentation CI on commit fca4b95.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

iocanel
iocanel approved these changes Mar 13, 2025
View reviewed changes
Copy link
Contributor

@iocanel iocanel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gsmet gsmet merged commit 67e69e7 into quarkusio:main Mar 13, 2025
5 checks passed
@quarkus-bot quarkus-bot bot added this to the 3.22 - main milestone Mar 13, 2025
@gsmet gsmet modified the milestones: 3.22 - main, 3.21.0 Mar 18, 2025
@gsmet gsmet modified the milestones: 3.21.0, 3.19.4 Mar 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iocanel iocanel iocanel approved these changes

Assignees
No one assigned
Labels
area/docstyle issues related for manual docstyle review area/documentation
Projects
None yet
Milestone
3.19.4
Development

Successfully merging this pull request may close these issues.
4 participants
@sheilamjones @MichalMaler @iocanel @gsmet