Use source file mapping for all compilation providers

[stuartwdouglas]

All compilation providers should be setting the source file attribute for use in debugging, there is no need to limit this to Java. This should allow for deletions of Kotlin classes to be handled correctly.

[quarkus-bot]

Thanks for your pull request!

Your pull request does not follow our editorial rules. Could you have a look?

• title should preferably start with an uppercase character (if it makes sense!)

_{This message is automatically generated by a bot.}

[quarkus-bot]

Status for workflow Quarkus CI

This is the status report for running Quarkus CI on commit c61a3e2.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

You can consult the Develocity build scans.

---

Flaky tests - Develocity

⚙️ JVM Tests - JDK 17

📦 extensions/infinispan-cache/deployment

✖ io.quarkus.cache.infinispan.InfinispanCacheTest.testGetAsyncWithParallelCalls - History

• expected: "thread1" but was: "thread2" - org.opentest4j.AssertionFailedError

org.opentest4j.AssertionFailedError: 

expected: "thread1"
 but was: "thread2"
	at io.quarkus.cache.infinispan.InfinispanCacheTest.testGetAsyncWithParallelCalls(InfinispanCacheTest.java:283)
	at java.base/java.lang.reflect.Method.invoke(Method.java:569)
	at io.quarkus.test.QuarkusUnitTest.runExtensionMethod(QuarkusUnitTest.java:521)
	at io.quarkus.test.QuarkusUnitTest.interceptTestMethod(QuarkusUnitTest.java:435)

---

⚙️ JVM Tests - JDK 21

📦 extensions/hibernate-orm/deployment

✖ io.quarkus.hibernate.orm.applicationfieldaccess.PublicFieldAccessAssociationsTest.testFieldAccess - History

• expected: io.quarkus.hibernate.orm.applicationfieldaccess.PublicFieldAccessAssociationsTest$ContainedEntity@2bac74dc but was: null - org.opentest4j.AssertionFailedError

org.opentest4j.AssertionFailedError: 

expected: io.quarkus.hibernate.orm.applicationfieldaccess.PublicFieldAccessAssociationsTest$ContainedEntity@2bac74dc
 but was: null
	at io.quarkus.hibernate.orm.applicationfieldaccess.PublicFieldAccessAssociationsTest$FieldAccessEnhancedDelegate$1.assertValueAndLaziness(PublicFieldAccessAssociationsTest.java:187)
	at io.quarkus.hibernate.orm.applicationfieldaccess.PublicFieldAccessAssociationsTest.doTestFieldAccess(PublicFieldAccessAssociationsTest.java:106)
	at io.quarkus.hibernate.orm.applicationfieldaccess.PublicFieldAccessAssociationsTest.testFieldAccess(PublicFieldAccessAssociationsTest.java:60)
	at java.base/java.lang.reflect.Method.invoke(Method.java:580)

[geoand]

Makes perfect sense, thanks!

[stuartwdouglas]

Any chance we could get this backported? Not sure what the procedure is these days.

[gsmet]

If you just want it in 3.19, I added the backport label and will include it in the next 3.19.

[gsmet]

It was preexisting but is there a reason why we are using a StringBuilder here and not the Path API given we already have Paths?

[stuartwdouglas]

I don't think so, I just moved the code, I didn't really look at it.

[stuartwdouglas]

If you just want it in 3.19, I added the backport label and will include it in the next 3.19.

Thanks!