Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify using table name in Security JPA guide #46581

Merged
merged 3 commits into from
Mar 2, 2025

Conversation

jcjveraa
Copy link
Contributor

@jcjveraa jcjveraa commented Mar 2, 2025

This tripped me up for a few minutes in a fresh project, could not see in all the logging what the exact issue was when I forgot to specify an @table annotation, causing Hibernate to generate the table as User. This might draw some more attention to it.

jcjveraa added 2 commits March 2, 2025 11:43
To make it more clear that you need to change the tablename
@quarkus-bot quarkus-bot bot added area/docstyle issues related for manual docstyle review area/documentation labels Mar 2, 2025

This comment has been minimized.

Copy link

github-actions bot commented Mar 2, 2025

🙈 The PR is closed and the preview is expired.

@sberyozkin
Copy link
Member

@jcjveraa Thanks for the PR

Copy link
Member

@sberyozkin sberyozkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, minor suggestions are proposed, thanks

Copy link

quarkus-bot bot commented Mar 2, 2025

Status for workflow Quarkus Documentation CI

This is the status report for running Quarkus Documentation CI on commit 926078c.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

@sberyozkin sberyozkin merged commit 71c44ad into quarkusio:main Mar 2, 2025
5 checks passed
@quarkus-bot quarkus-bot bot added this to the 3.21 - main milestone Mar 2, 2025
@gsmet gsmet modified the milestones: 3.21 - main, 3.19.2 Mar 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/docstyle issues related for manual docstyle review area/documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants