Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

makes Kafka Streams topology optional #46576

Merged
merged 1 commit into from
Mar 3, 2025
Merged

makes Kafka Streams topology optional #46576

merged 1 commit into from
Mar 3, 2025

Conversation

dcotfr
Copy link
Contributor

@dcotfr dcotfr commented Feb 28, 2025 •
edited by cescoffier
Loading

DevUI behavior if the kafka-streams extension is present but no topology is provided.

  • before this fix: blocking UnsatisfiedResolutionException at startup, in dev mode.
  • after this fix: Ok start of the DevUI, with an empty topology displayed by default.

Fix #40315
Fix #41432

This was referenced Feb 28, 2025
Closed
Closed
@dcotfr dcotfr force-pushed the issues-40315-and-41432 branch from b60400c to 614d0f0 Compare February 28, 2025 23:57
@michalvavrik michalvavrik requested a review from ozangunalp March 1, 2025 12:45
cescoffier
cescoffier approved these changes Mar 2, 2025
View reviewed changes
Copy link
Member

@cescoffier cescoffier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@quarkus-bot quarkus-bot
Copy link

quarkus-bot bot commented Mar 2, 2025 •
edited by github-actions bot
Loading

Status for workflow Quarkus CI

This is the status report for running Quarkus CI on commit 614d0f0.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

You can consult the Develocity build scans.

@cescoffier cescoffier changed the title Resolves 40315 & 41432 issues makes Kafka Streams topology optional Mar 3, 2025
@cescoffier
Copy link
Member

cescoffier commented Mar 3, 2025 •
edited
Loading

@ozangunalp, can you have a look?

Passing an empty string seems a bit weird, but if that’s expected, it’s fine. In this case, maybe one improvement could be to return an empty JSON object.

ozangunalp
ozangunalp approved these changes Mar 3, 2025
View reviewed changes
Copy link
Contributor

@ozangunalp ozangunalp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good to me too. The empty string is handled in the Dev UI.

@ozangunalp ozangunalp merged commit 503e496 into quarkusio:main Mar 3, 2025
26 checks passed
@quarkus-bot quarkus-bot bot added this to the 3.21 - main milestone Mar 3, 2025
@gsmet gsmet modified the milestones: 3.21 - main, 3.19.2 Mar 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ozangunalp ozangunalp ozangunalp approved these changes

@cescoffier cescoffier cescoffier approved these changes

Assignees
No one assigned
Labels
area/kafka-streams kind/bugfix
Projects
None yet
Milestone
3.19.2
4 participants
@dcotfr @cescoffier @ozangunalp @gsmet