-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix docker templates and platform to support ubi8 and ubi9 #46567
Conversation
5049a24
to
46f920a
Compare
There is not point on using ubi9 on the codestart generation test which use mock data and is not testing |
This comment has been minimized.
This comment has been minimized.
Here are the commands I tested: qs3.18 create app foo-3.19-17-old -P=io.quarkus::999-SNAPSHOT --java=17
qs3.18 create app foo-3.19-21-old -P=io.quarkus::999-SNAPSHOT --java=21
qss create app foo-3.18 -S=3.18
qss create app foo-3.19 -P=io.quarkus::999-SNAPSHOT
qss create app foo-3.19-17 -P=io.quarkus::999-SNAPSHOT --java=17 |
devtools/gradle/build-logic/.kotlin/errors/errors-1740752182994.log
Outdated
Show resolved
Hide resolved
46f920a
to
1926cc3
Compare
This comment has been minimized.
This comment has been minimized.
1926cc3
to
430d1db
Compare
Status for workflow
|
@cescoffier @ia3andy @aloubyansky @gastaldi let's make sure we address this tomorrow as we need a fix for the next 3.19 (and I will probably try to release something on Wednesday). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM,
It would be helpful to to add a comment explaining why in the codestart template we stick to UBI8 images (for my future self)
@@ -5,6 +5,6 @@ language: | |||
data: | |||
dockerfile: | |||
native: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we add a comment (it's yaml, so we can) explaining why here we want to stay on UBI8 and not switch to UBI9?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will merge it so that I can backport it this evening but I agree with @cescoffier that a comment would be nice.
It can be done as a followup.
Supersed #46538
Current Challenges
Solution
platform.codestart.metadata.dockerfile.from.XX
to UBI9.New Behavior