Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ArC: consider built-in session context during client proxy optimization #46561

Merged
merged 1 commit into from
Feb 28, 2025
Merged

ArC: consider built-in session context during client proxy optimization #46561

merged 1 commit into from
Feb 28, 2025

Conversation

mkouba
Copy link
Contributor

@mkouba mkouba commented Feb 28, 2025

@mkouba mkouba requested a review from manovotn February 28, 2025 12:11
@quarkus-bot quarkus-bot bot added the area/arc Issue related to ARC (dependency injection) label Feb 28, 2025
@mkouba mkouba marked this pull request as draft February 28, 2025 12:18
@mkouba
ArC: consider built-in session context during client proxy optimization
8e3211c 
- the problem occurs when quarkus-websockets-next and quarkus-undertow
extensions are used at the same time
- fixes quarkusio#46548
@mkouba mkouba marked this pull request as ready for review February 28, 2025 12:46
@Ladicek
Copy link
Contributor

Ladicek commented Feb 28, 2025

Do we have a built-in session context? AFAIK, we only have the Undertow session context and WebSockets Next session context, no?

@mkouba
Copy link
Contributor Author

mkouba commented Feb 28, 2025

Do we have a built-in session context? AFAIK, we only have the Undertow session context and WebSockets Next session context, no?

Yes, we do: #45170. WebSockets Next is using the built-in session context.

@Ladicek
Copy link
Contributor

Ladicek commented Feb 28, 2025

Ah interesting, thanks! I vaguely recall seeing that PR, but I forgot about it :-)

@mkouba mkouba added the triage/waiting-for-ci Ready to merge when CI successfully finishes label Feb 28, 2025
@quarkus-bot quarkus-bot
Copy link

quarkus-bot bot commented Feb 28, 2025 •
edited by github-actions bot
Loading

Status for workflow Quarkus CI

This is the status report for running Quarkus CI on commit 8e3211c.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

You can consult the Develocity build scans.

@mkouba mkouba merged commit 0208ffd into quarkusio:main Feb 28, 2025
58 checks passed
@quarkus-bot quarkus-bot bot removed the triage/waiting-for-ci Ready to merge when CI successfully finishes label Feb 28, 2025
@quarkus-bot quarkus-bot bot added this to the 3.21 - main milestone Feb 28, 2025
@gsmet gsmet modified the milestones: 3.21 - main, 3.19.2 Mar 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ladicek Ladicek Ladicek approved these changes

@manovotn manovotn Awaiting requested review from manovotn

Assignees
No one assigned
Labels
area/arc Issue related to ARC (dependency injection) kind/bugfix
Projects
None yet
Milestone
3.19.2
Development

Successfully merging this pull request may close these issues.

Websockets next incompatible with undertow extension when using @SessionScoped
3 participants
@mkouba @Ladicek @gsmet