DevUI: fix bean/build steps depenceny graphs #46558
Merged
+79
−56
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- also simplify bean dependency graph and remove the direct dependency/dependent category
quarkus-bot
bot
added
area/arc
mkouba
commented
Feb 28, 2025
| @@ -65,40 +65,48 @@ export class QwcArcBeanGraph extends LitElement { | |||
| this._links = [] | |||
| this._nodes = [] | |||
| for (var l = 0; l < dependencyGraphsLinks.length; l++) { | |||
| let link = new Object(); | |||
| link.source = dependencyGraphsNodes.findIndex(item => item.id === dependencyGraphsLinks[l].source); | |||
There was a problem hiding this comment.
This was the problematic part - the node index value was derived from the dependencyGraphsNodes array but the graph data are stored in this._nodes. These two arrays have the same size but different ordering.
phillip-kruger
approved these changes
Feb 28, 2025
Status for workflow
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems that these graphs were broken in the new Dev UI from the beginning but no one complained so it's probably not frequently used 🤷.