Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove quarkus-mutiny dependency from container-image extensions #46557

Conversation

ozangunalp
Copy link
Contributor

@ozangunalp ozangunalp commented Feb 28, 2025

DevUI JsonRPC services are called on worker threads if the signature is blocking.

Removes the unnecessary dependency. quarkus-mutiny pulls the context-propagation extensions when adding container-image extensions.

@phillip-kruger I can't open the new Dev UI (even without this change), I don't know if it is related to #46527

@phillip-kruger
Copy link
Member

@ozangunalp - #46527 does not really break anything. It's been like that from the start, so not the reason your Dev UI is not loading.

This comment has been minimized.

This comment has been minimized.

Copy link

github-actions bot commented Feb 28, 2025

🎊 PR Preview bc14c86 has been successfully built and deployed to https://quarkus-pr-main-46557-preview.surge.sh/version/main/guides/

  • Images of blog posts older than 3 months are not available.
  • Newsletters older than 3 months are not available.

@ozangunalp ozangunalp force-pushed the rm_quarkus_mutiny_dep_from_container_image_extensions branch from 66c9456 to 7f8b4ed Compare February 28, 2025 11:58
@ozangunalp ozangunalp force-pushed the rm_quarkus_mutiny_dep_from_container_image_extensions branch from 7f8b4ed to fe18386 Compare February 28, 2025 12:17
@ozangunalp
Copy link
Contributor Author

container-image IT container-native-main failed because container-image no longer pulls quarkus-arc transitively.
Added that dependency to the test project.

@phillip-kruger

Copy link
Member

@phillip-kruger phillip-kruger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ozangunalp ozangunalp added the triage/waiting-for-ci Ready to merge when CI successfully finishes label Feb 28, 2025
Copy link

quarkus-bot bot commented Feb 28, 2025

Status for workflow Quarkus CI

This is the status report for running Quarkus CI on commit fe18386.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

Warning

There are other workflow runs running, you probably need to wait for their status before merging.

You can consult the Develocity build scans.

Copy link

quarkus-bot bot commented Feb 28, 2025

Status for workflow Quarkus Documentation CI

This is the status report for running Quarkus Documentation CI on commit fe18386.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

@ozangunalp ozangunalp merged commit a5aeff1 into quarkusio:main Feb 28, 2025
32 checks passed
@quarkus-bot quarkus-bot bot removed the triage/waiting-for-ci Ready to merge when CI successfully finishes label Feb 28, 2025
@quarkus-bot quarkus-bot bot added this to the 3.21 - main milestone Feb 28, 2025
@gsmet
Copy link
Member

gsmet commented Mar 3, 2025

@ozangunalp is it supposed to fix an issue and does it need to get backported to 3.19?

@ozangunalp
Copy link
Contributor Author

@gsmet, it is a nice to have. We do not need to pull quarkus-mutiny and quarkus-context-propagation in some extension combinations.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants