-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove quarkus-mutiny dependency from container-image extensions #46557
Remove quarkus-mutiny dependency from container-image extensions #46557
Conversation
@ozangunalp - #46527 does not really break anything. It's been like that from the start, so not the reason your Dev UI is not loading. |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
🎊 PR Preview bc14c86 has been successfully built and deployed to https://quarkus-pr-main-46557-preview.surge.sh/version/main/guides/
|
66c9456
to
7f8b4ed
Compare
7f8b4ed
to
fe18386
Compare
container-image IT container-native-main failed because container-image no longer pulls quarkus-arc transitively. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Status for workflow
|
Status for workflow
|
@ozangunalp is it supposed to fix an issue and does it need to get backported to 3.19? |
@gsmet, it is a nice to have. We do not need to pull quarkus-mutiny and quarkus-context-propagation in some extension combinations. |
DevUI JsonRPC services are called on worker threads if the signature is blocking.
Removes the unnecessary dependency.
quarkus-mutiny
pulls the context-propagation extensions when adding container-image extensions.@phillip-kruger I can't open the new Dev UI (even without this change), I don't know if it is related to #46527