Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch docs and samples to use CORS and JSON enabled properties #46534

Merged
merged 3 commits into from
Feb 28, 2025

Conversation

wjglerum
Copy link
Contributor

Recently quarkus.http.cors=true was updated to quarkus.http.cors.enabled=true.

This PR also reflects that in the docs, tests and samples. We should probably do the same for the log properties quarkus.log.*.json

https://quarkus.io/blog/quarkus-3-19-1-released/#migration-to-configmapping
https://github.com/quarkusio/quarkus/wiki/Migration-Guide-3.19#other-changes-gear-white_check_mark

Not sure what to do with the SmallRyeOpenApiProcessor as it does not check for the new property (yet), should we for compatibility check both?

Recently `quarkus.http.cors=true` was updated to `quarkus.http.cors.enabled=true`. This PR also reflects that in the docs, tests and samples.
@sberyozkin
Copy link
Member

Thanks @wjglerum, IMHO at least one CORS test should continue testing the old property, which is still likely to be used a lot, even though it is deprecated

@wjglerum
Copy link
Contributor Author

Thanks @wjglerum, IMHO at least one CORS test should continue testing the old property, which is still likely to be used a lot, even though it is deprecated

Good point, will add a basic one 👍

@gsmet
Copy link
Member

gsmet commented Feb 27, 2025

We should probably do the same for the log properties quarkus.log.*.json

Yes, if you have the time, please do!

@wjglerum
Copy link
Contributor Author

We should probably do the same for the log properties quarkus.log.*.json

Yes, if you have the time, please do!

Will do that too then, would you prefer a separate PR or shall I combine it with this one?

Copy link
Member

@gsmet gsmet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

I agree with Sergey that it would be nice to have a small test (one is enough!) for the deprecated config. I would just copy an existing one and be done with it.

This comment has been minimized.

Copy link

github-actions bot commented Feb 27, 2025

🙈 The PR is closed and the preview is expired.

@wjglerum
Copy link
Contributor Author

I agree with Sergey that it would be nice to have a small test (one is enough!) for the deprecated config. I would just copy an existing one and be done with it.

Just added that 👍

This comment has been minimized.

@quarkus-bot quarkus-bot bot added area/docstyle issues related for manual docstyle review area/logging labels Feb 27, 2025

This comment has been minimized.

@wjglerum wjglerum changed the title Switch docs and samples to CORS enabled property Switch docs and samples to use CORS and JSON enabled properties Feb 27, 2025

This comment has been minimized.

This comment has been minimized.

@wjglerum
Copy link
Contributor Author

@gsmet this should be ready now

Copy link
Member

@gsmet gsmet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@gsmet gsmet force-pushed the update-cors-enabled-property branch from 7ffb266 to f8c608c Compare February 27, 2025 20:16
@gsmet
Copy link
Member

gsmet commented Feb 27, 2025

I rebased to squash the fix commit to sort the imports. Will merge tomorrow.

@gsmet gsmet added the triage/waiting-for-ci Ready to merge when CI successfully finishes label Feb 27, 2025
Copy link

quarkus-bot bot commented Feb 27, 2025

Status for workflow Quarkus Documentation CI

This is the status report for running Quarkus Documentation CI on commit f8c608c.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

Warning

There are other workflow runs running, you probably need to wait for their status before merging.

Copy link

quarkus-bot bot commented Feb 27, 2025

Status for workflow Quarkus CI

This is the status report for running Quarkus CI on commit f8c608c.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

You can consult the Develocity build scans.

@gsmet gsmet merged commit 8e7ab39 into quarkusio:main Feb 28, 2025
35 checks passed
@quarkus-bot quarkus-bot bot removed the triage/waiting-for-ci Ready to merge when CI successfully finishes label Feb 28, 2025
@quarkus-bot quarkus-bot bot added this to the 3.21 - main milestone Feb 28, 2025
@gsmet
Copy link
Member

gsmet commented Feb 28, 2025

Thanks a lot!

@gsmet gsmet modified the milestones: 3.21 - main, 3.19.2 Mar 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants