-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch docs and samples to use CORS and JSON enabled properties #46534
Conversation
Recently `quarkus.http.cors=true` was updated to `quarkus.http.cors.enabled=true`. This PR also reflects that in the docs, tests and samples.
Thanks @wjglerum, IMHO at least one CORS test should continue testing the old property, which is still likely to be used a lot, even though it is deprecated |
Good point, will add a basic one 👍 |
Yes, if you have the time, please do! |
Will do that too then, would you prefer a separate PR or shall I combine it with this one? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
I agree with Sergey that it would be nice to have a small test (one is enough!) for the deprecated config. I would just copy an existing one and be done with it.
...eployment/src/main/java/io/quarkus/smallrye/openapi/deployment/SmallRyeOpenApiProcessor.java
Show resolved
Hide resolved
This comment has been minimized.
This comment has been minimized.
🙈 The PR is closed and the preview is expired. |
Just added that 👍 |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
@gsmet this should be ready now |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
7ffb266
to
f8c608c
Compare
I rebased to squash the fix commit to sort the imports. Will merge tomorrow. |
Status for workflow
|
Status for workflow
|
Thanks a lot! |
Recently
quarkus.http.cors=true
was updated toquarkus.http.cors.enabled=true
.This PR also reflects that in the docs, tests and samples. We should probably do the same for the log properties
quarkus.log.*.json
https://quarkus.io/blog/quarkus-3-19-1-released/#migration-to-configmapping
https://github.com/quarkusio/quarkus/wiki/Migration-Guide-3.19#other-changes-gear-white_check_mark
Not sure what to do with the
SmallRyeOpenApiProcessor
as it does not check for the new property (yet), should we for compatibility check both?