Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Properly implement support for gzip responses in REST Client #46499

Merged
merged 2 commits into from
Feb 28, 2025

Conversation

geoand
Copy link
Contributor

@geoand geoand commented Feb 25, 2025

P.S. This also opens the door for the REST Client to support other compressed types of payloads that Vert.x supports.

This comment has been minimized.

Copy link

quarkus-bot bot commented Feb 25, 2025

Status for workflow Quarkus CI

This is the status report for running Quarkus CI on commit 37baf0f.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

You can consult the Develocity build scans.


Flaky tests - Develocity

⚙️ JVM Tests - JDK 17 Windows

📦 extensions/scheduler/deployment

io.quarkus.scheduler.test.timezone.TriggerPrevFireTimeZoneTest.testScheduledJobs - History

  • expected: <true> but was: <false> - org.opentest4j.AssertionFailedError
org.opentest4j.AssertionFailedError: expected: <true> but was: <false>
	at org.junit.jupiter.api.AssertionFailureBuilder.build(AssertionFailureBuilder.java:151)
	at org.junit.jupiter.api.AssertionFailureBuilder.buildAndThrow(AssertionFailureBuilder.java:132)
	at org.junit.jupiter.api.AssertTrue.failNotTrue(AssertTrue.java:63)
	at org.junit.jupiter.api.AssertTrue.assertTrue(AssertTrue.java:36)
	at org.junit.jupiter.api.AssertTrue.assertTrue(AssertTrue.java:31)
	at org.junit.jupiter.api.Assertions.assertTrue(Assertions.java:183)
	at io.quarkus.scheduler.test.timezone.TriggerPrevFireTimeZoneTest.testScheduledJobs(TriggerPrevFireTimeZoneTest.java:61)

@geoand
Copy link
Contributor Author

geoand commented Feb 27, 2025

@cescoffier is there anything else you would want me to do with this one?

Thanks

@cescoffier cescoffier merged commit 519f562 into quarkusio:main Feb 28, 2025
38 checks passed
@quarkus-bot quarkus-bot bot added this to the 3.21 - main milestone Feb 28, 2025
@quarkus-bot quarkus-bot bot added the kind/enhancement New feature or request label Feb 28, 2025
@geoand geoand deleted the #46496 branch February 28, 2025 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Reevaluate the compression handling of the REST Client
2 participants