Use quarkus-security-test-utils and quarkus-arc-test-supplement dependencies within a test scope

[michalvavrik]

I mentioned scope of these dependencies isn't what I expected when I analyzed Quarkus core dependencies that are not managed by Quarkus BOM. I expected they will have a test scope but nope.

• quarkus-security-test-utils here I am pretty sure that compile scope doesn't make sense because we don't expect other deployment modules of extensions will use this internal tool; if they need it, they should include it explicitly
• quarkus-arc-test-supplement seems like purely test scope dependency, but there can be a reason why it must be in a compile scope I don't know about

[quarkus-bot]

Status for workflow Quarkus Documentation CI

This is the status report for running Quarkus Documentation CI on commit 0e2f257.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

Warning

There are other workflow runs running, you probably need to wait for their status before merging.

[github-actions]

🎊 PR Preview 453add3 has been successfully built and deployed to https://quarkus-pr-main-46497-preview.surge.sh/version/main/guides/

• Images of blog posts older than 3 months are not available.
• Newsletters older than 3 months are not available.

[quarkus-bot]

Status for workflow Quarkus CI

This is the status report for running Quarkus CI on commit 0e2f257.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

You can consult the Develocity build scans.

---

Flaky tests - Develocity

⚙️ JVM Tests - JDK 17 Windows

📦 extensions/hibernate-orm/deployment

✖ io.quarkus.hibernate.orm.applicationfieldaccess.PublicFieldAccessInheritanceTest.testFieldAccess - History

• Expecting actual not to be null - java.lang.AssertionError

java.lang.AssertionError: 

Expecting actual not to be null
	at io.quarkus.hibernate.orm.applicationfieldaccess.PublicFieldAccessInheritanceTest$FieldAccessEnhancedDelegate$2.assertValue(PublicFieldAccessInheritanceTest.java:152)
	at io.quarkus.hibernate.orm.applicationfieldaccess.PublicFieldAccessInheritanceTest.doTestFieldAccess(PublicFieldAccessInheritanceTest.java:100)
	at io.quarkus.hibernate.orm.applicationfieldaccess.PublicFieldAccessInheritanceTest.testFieldAccess(PublicFieldAccessInheritanceTest.java:61)
	at java.base/java.lang.reflect.Method.invoke(Method.java:569)
	at io.quarkus.test.QuarkusUnitTest.runExtensionMethod(QuarkusUnitTest.java:513)

• Expecting actual not to be null - java.lang.AssertionError

java.lang.AssertionError: 

Expecting actual not to be null
	at io.quarkus.hibernate.orm.applicationfieldaccess.PublicFieldAccessInheritanceTest$FieldAccessEnhancedDelegate$2.assertValue(PublicFieldAccessInheritanceTest.java:152)
	at io.quarkus.hibernate.orm.applicationfieldaccess.PublicFieldAccessInheritanceTest.doTestFieldAccess(PublicFieldAccessInheritanceTest.java:100)
	at io.quarkus.hibernate.orm.applicationfieldaccess.PublicFieldAccessInheritanceTest.testFieldAccess(PublicFieldAccessInheritanceTest.java:61)
	at java.base/java.lang.reflect.Method.invoke(Method.java:569)
	at io.quarkus.test.QuarkusUnitTest.runExtensionMethod(QuarkusUnitTest.java:513)

[michalvavrik]

hey @mkouba , is changing scope of the quarkus-arc-test-supplement correct?

[mkouba]

hey @mkouba , is changing scope of the quarkus-arc-test-supplement correct?

It looks ok but until now I had no idea what quarkus-arc-test-supplement actually is. It might be better to ask @Ladicek!

[Ladicek]

Making quarkus-arc-test-supplement test-scoped is OK, I'm not sure why I didn't make it test-scoped initially. It's only used in deployment tests.

[michalvavrik]

Making quarkus-arc-test-supplement test-scoped is OK, I'm not sure why I didn't make it test-scoped initially. It's only used in deployment tests.

Alright, thanks.

[gsmet]

Good catch!