Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

QuarkusComponentTest: add basic support for nested test classes #46487

Merged
merged 1 commit into from
Feb 26, 2025
Merged

QuarkusComponentTest: add basic support for nested test classes #46487

merged 1 commit into from
Feb 26, 2025

Conversation

mkouba
Copy link
Contributor

@mkouba mkouba commented Feb 25, 2025

@mkouba mkouba requested a review from manovotn February 25, 2025 16:12
@quarkus-bot quarkus-bot

This comment has been minimized.

Sign in to view
@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 25, 2025 •
edited
Loading

🙈 The PR is closed and the preview is expired.

@quarkus-bot quarkus-bot

This comment has been minimized.

Sign in to view
@quarkus-bot quarkus-bot

This comment has been minimized.

Sign in to view
@mkouba
Copy link
Contributor Author

mkouba commented Feb 26, 2025

Test failures are very likely not related.

manovotn
manovotn reviewed Feb 26, 2025
View reviewed changes
Copy link
Contributor

@manovotn manovotn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one note WRT tests, otherwise looks good

@manovotn manovotn added the triage/waiting-for-ci Ready to merge when CI successfully finishes label Feb 26, 2025
@quarkus-bot quarkus-bot
Copy link

quarkus-bot bot commented Feb 26, 2025

Status for workflow Quarkus Documentation CI

This is the status report for running Quarkus Documentation CI on commit 7cda115.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

@quarkus-bot quarkus-bot
Copy link

quarkus-bot bot commented Feb 26, 2025 •
edited by github-actions bot
Loading

Status for workflow Quarkus CI

This is the status report for running Quarkus CI on commit 7cda115.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

You can consult the Develocity build scans.

@mkouba mkouba merged commit 0d8bf11 into quarkusio:main Feb 26, 2025
32 checks passed
@quarkus-bot quarkus-bot bot removed the triage/waiting-for-ci Ready to merge when CI successfully finishes label Feb 26, 2025
@quarkus-bot quarkus-bot bot added this to the 3.21 - main milestone Feb 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@manovotn manovotn manovotn approved these changes

Assignees
No one assigned
Labels
area/documentation area/testing kind/bugfix
Projects
None yet
Milestone
3.21.0.CR1
Development

Successfully merging this pull request may close these issues.

@QuarkusComponentTest fails on nested test classes
2 participants
@mkouba @manovotn