Logging with Panache: add support for method references of Log methods
#46479
+214
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmlloyd
reviewed
Feb 25, 2025
core/deployment/src/main/java/io/quarkus/deployment/logging/LoggingWithPanacheProcessor.java
Show resolved
Hide resolved
This comment has been minimized.
This comment has been minimized.
dmlloyd
approved these changes
Feb 25, 2025
In case the `Log` API is used in a lambda expression, everything already works, because a lambda expression body is compiled into a separate method and the `Log` API is invoked using classic `invokestatic` instruction. However, in case the `Log` API is used as a method reference (`Log::info`), it breaks, because the `LoggingWithPanacheProcessor` fails to transform that usage. This commit fixes that by looking for `invokedynamic` invocations of the `LambdaMetafactory` where the method handle belongs to `Log`. Such instructions are rewritten to delegate to the JBoss Logging instance, as usual.
Ladicek
force-pushed
the
logging-method-references-fix
branch
from
5e4f1cc to
44b3ce4
Compare
|
Added a couple of comments and streamlined the code: instead of looking for the Also using this opportunity to rerun the failed tests, because those don't seem related on the first sight. If they fail again, I'll investigate properly :-) |
Status for workflow
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In case the
LogAPI is used in a lambda expression, everything already works, because a lambda expression body is compiled into a separate method and theLogAPI is invoked using classicinvokestaticinstruction.However, in case the
LogAPI is used as a method reference (Log::info), it breaks, because theLoggingWithPanacheProcessorfails to transform that usage. This commit fixes that by looking forinvokedynamicinvocations of theLambdaMetafactorywhere the method handle belongs toLog. Such instructions are rewritten to delegate to the JBoss Logging instance, as usual.