Check reachability of sub resources before indexing them #46464
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes sure, that the absent and present sub resources can actually be reached from a root resource class in the server endpoint indexer. Otherwise, e.g. client sub resource interface could get indexed as server endpoints
Status for workflow
|
geoand
reviewed
Feb 25, 2025
| } | ||
|
|
||
| public interface UndangerousGoodsResource { | ||
| // not even dangerous enough to get a resource method |
geoand
reviewed
Feb 25, 2025
| return typeName; | ||
| } else if (type.kind() == Type.Kind.PARAMETERIZED_TYPE | ||
| && typeName.equals(DotName.createSimple(Class.class))) { | ||
| // spec allows for Class<SubResource> to be returned that the container should instantiate |
There was a problem hiding this comment.
I didn't know that and don't think I've ever seen it used :)
There was a problem hiding this comment.
I was surprised, to say the least :)
|
Thanks for following up on this! |
gsmet
added a commit
to gsmet/quarkus
that referenced
this pull request
Feb 26, 2025
This is a follow-up of quarkusio#46464. Given the purpose of the PR was to improve dev mode reload performance, I think it's worth avoid the extra allocations.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes sure, that the absent and present sub resources can actually be reached from a root resource class in the server endpoint indexer. Otherwise, e.g. client sub resource interface could get indexed as server endpoints.
I measured following times during hot reload.
With 2df8c69:
2df8c69 + this patch
improves hot reload times by about 80ms
related to #45631
replaces #46325