-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Redis Client: Refactored Exception Throwing in Uni Functions #46439
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Makes sense to me. WDYT @cescoffier?
This comment has been minimized.
This comment has been minimized.
Executed formatter in |
Yes, makes sense. |
This comment has been minimized.
This comment has been minimized.
@khosbilegt I fixed the PR in your branch (and also squashed the previous 2 commits), please don't do anything with this PR anymore :-) We'll merge once tests finish. |
Status for workflow
|
Some of the Redis Client methods that returned Unis were throwing Exceptions rather than returning Unis created from the exceptions.
This was causing issues where the exceptions weren't being caught in .onFailure() blocks and required the classic try catch approach, especially hindersome in Multi pipelines.