Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make URL inherit TestHTTPEndpoint from class level #46410

Merged

Conversation

gian1200
Copy link
Contributor

@gian1200 gian1200 commented Feb 21, 2025

Functionality:

  • If a Test Class is annotated with @TestHTTPEndpoint then all fields annotated with @TestHTTPResource inherit it's configuration.
  • If field is also annotated with @TestHTTPEndpoint, field's annotation takes precedence.
  • Will only work if @TestHTTPResource annotation is used on field (AS-IS)

Tests

Additional notes:

  • I couldn't find the tests for original functionality, so I included both (new and original).
  • I reused some resources/endpoints. Not sure if that's acceptable/expected or not (hopefully it doesn't make other tests fail)
  • Added more tests to cover Unable to inject TestHTTPResource field #46336

References

This comment has been minimized.

@geoand geoand force-pushed the feature/testhttpendpoint-inheritance branch from a47a12f to c9270be Compare February 24, 2025 14:54
@geoand geoand self-requested a review February 25, 2025 11:52

This comment has been minimized.

@gian1200
Copy link
Contributor Author

gian1200 commented Feb 25, 2025

Not sure how to interpret the Quarkus CI report. Those 3 were +24 hours queued. Previous run was successful for those 3.
Also, "JVM Tests - JDK 17 Windows" passed, but it's stilled flagged as "flaky".

image

I'm going to rebase it. Maybe that fixes everything 🙏🏻 .


Update

"Quarkus CI" status on local repo: https://github.com/gian1200/quarkus/actions/runs/13532624822

@gian1200 gian1200 force-pushed the feature/testhttpendpoint-inheritance branch from c9270be to fc1ea68 Compare February 25, 2025 22:59

This comment has been minimized.

Copy link

quarkus-bot bot commented Feb 26, 2025

Status for workflow Quarkus CI

This is the status report for running Quarkus CI on commit fc1ea68.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

You can consult the Develocity build scans.

@geoand geoand merged commit 1562be0 into quarkusio:main Feb 26, 2025
58 checks passed
@quarkus-bot quarkus-bot bot added this to the 3.21 - main milestone Feb 26, 2025
@quarkus-bot quarkus-bot bot added the kind/enhancement New feature or request label Feb 26, 2025
@gian1200 gian1200 deleted the feature/testhttpendpoint-inheritance branch March 7, 2025 00:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make TestHTTPEndpoint at class level affect all URL fields in test classes
2 participants