Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restructure TLS Registry Extension #46387

Merged
merged 1 commit into from
Mar 1, 2025

Conversation

cescoffier
Copy link
Member

This PR reorganizes the TLS registry extension according to the guidelines discussed in #43130.

Fixes #44711.

This change will result in extensions relying on the TLS registry build item encountering a breaking change due to the updated package name.

Copy link

quarkus-bot bot commented Feb 20, 2025

/cc @brunobat (opentelemetry), @radcortez (opentelemetry)

This comment has been minimized.

Copy link

github-actions bot commented Feb 20, 2025

🎊 PR Preview 519f562 has been successfully built and deployed to https://quarkus-pr-main-46387-preview.surge.sh/version/main/guides/

  • Images of blog posts older than 3 months are not available.
  • Newsletters older than 3 months are not available.

This comment has been minimized.

@cescoffier
Copy link
Member Author

@gsmet @geoand @dmlloyd This is an attempt to follow the recommendations from #43130.

Copy link
Contributor

@geoand geoand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes perfect sense to me

@cescoffier cescoffier force-pushed the tls-registry-split-package branch from 1ecd436 to 8e93ec3 Compare February 24, 2025 16:04

This comment has been minimized.

This comment has been minimized.

This commit reorganizes the TLS registry extension according to the guidelines discussed in quarkusio#43130.

The restructuring addresses the issue logged in quarkusio#44711.

As a result of this change, extensions relying on the TLS registry build item will encounter a breaking change due to the updated package name.
@cescoffier cescoffier force-pushed the tls-registry-split-package branch from 8e93ec3 to dea354a Compare February 28, 2025 07:50
@cescoffier cescoffier added the triage/waiting-for-ci Ready to merge when CI successfully finishes label Feb 28, 2025
Copy link

quarkus-bot bot commented Feb 28, 2025

Status for workflow Quarkus Documentation CI

This is the status report for running Quarkus Documentation CI on commit dea354a.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

Warning

There are other workflow runs running, you probably need to wait for their status before merging.

Copy link

quarkus-bot bot commented Feb 28, 2025

Status for workflow Quarkus CI

This is the status report for running Quarkus CI on commit dea354a.

Failing Jobs

Status Name Step Failures Logs Raw logs Build scan
MicroProfile TCKs Tests Verify Failures Logs Raw logs 🔍

You can consult the Develocity build scans.

Failures

⚙️ MicroProfile TCKs Tests #

- Failing: tcks/microprofile-opentelemetry 

📦 tcks/microprofile-opentelemetry

Failed to execute goal org.apache.maven.plugins:maven-surefire-plugin:3.5.2:test (tracing) on project quarkus-tck-microprofile-opentelemetry: There are test failures.

See /home/runner/_work/quarkus/quarkus/tcks/microprofile-opentelemetry/target/surefire-reports-tracing for the individual test results.
See dump files (if any exist) [date].dump, [date]-jvmRun[N].dump and [date].dumpstream.


Flaky tests - Develocity

⚙️ JVM Tests - JDK 17 Windows

📦 extensions/hibernate-orm/deployment

io.quarkus.hibernate.orm.applicationfieldaccess.PublicFieldAccessInheritanceTest.testFieldAccess - History

  • Expecting actual not to be null - java.lang.AssertionError
java.lang.AssertionError: 

Expecting actual not to be null
	at io.quarkus.hibernate.orm.applicationfieldaccess.PublicFieldAccessInheritanceTest$FieldAccessEnhancedDelegate$2.assertValue(PublicFieldAccessInheritanceTest.java:152)
	at io.quarkus.hibernate.orm.applicationfieldaccess.PublicFieldAccessInheritanceTest.doTestFieldAccess(PublicFieldAccessInheritanceTest.java:100)
	at io.quarkus.hibernate.orm.applicationfieldaccess.PublicFieldAccessInheritanceTest.testFieldAccess(PublicFieldAccessInheritanceTest.java:61)
	at java.base/java.lang.reflect.Method.invoke(Method.java:569)
	at io.quarkus.test.QuarkusUnitTest.runExtensionMethod(QuarkusUnitTest.java:521)

@cescoffier cescoffier merged commit 880389b into quarkusio:main Mar 1, 2025
59 of 60 checks passed
@quarkus-bot quarkus-bot bot removed the triage/waiting-for-ci Ready to merge when CI successfully finishes label Mar 1, 2025
@quarkus-bot quarkus-bot bot added this to the 3.21 - main milestone Mar 1, 2025
@cescoffier cescoffier deleted the tls-registry-split-package branch March 10, 2025 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

io.quarkus.tls is split across extensions/tls-registry/deployment and extensions/tls-registry/runtime
4 participants