Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warn if using old @ConfigRoot class configuration mechanism #46314

Merged
merged 2 commits into from
Mar 14, 2025

Conversation

radcortez
Copy link
Member

No description provided.

This comment has been minimized.


if (configRoot.getAnnotation(Deprecated.class) == null) {
log.warn(configRoot.getName()
+ " is considered legacy and should be moved to use an interface and @ConfigMapping");
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be nice to have an URL to explain why and how to do that:

Suggested change
+ " is considered legacy and should be moved to use an interface and @ConfigMapping");
+ " is considered legacy and should be moved to use an interface and @ConfigMapping. See https://quarkus.io/guides/config-mappings for more info");

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, the message needs some tweaking, I will have a look soon.

It might be a bit too early to push it anyway.

Copy link
Member

@gsmet gsmet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pending minor adjustments.


if (configRoot.getAnnotation(Deprecated.class) == null) {
log.warn(configRoot.getName()
+ " is considered legacy and should be moved to use an interface and @ConfigMapping");
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, the message needs some tweaking, I will have a look soon.

It might be a bit too early to push it anyway.

Also only display one warning for all configuration roots.
Copy link
Member

@gsmet gsmet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I improved things a little bit, it should be good to go now.

@gsmet gsmet added the triage/waiting-for-ci Ready to merge when CI successfully finishes label Mar 14, 2025
Copy link

quarkus-bot bot commented Mar 14, 2025

Status for workflow Quarkus CI

This is the status report for running Quarkus CI on commit cb946a3.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

You can consult the Develocity build scans.


Flaky tests - Develocity

⚙️ JVM Tests - JDK 21

📦 extensions/opentelemetry/deployment

io.quarkus.opentelemetry.deployment.traces.OpenTelemetrySpanSecurityEventsTest.testSecurityEventTypes - History

  • event executor terminated - java.util.concurrent.RejectedExecutionException
java.util.concurrent.RejectedExecutionException: event executor terminated
	at io.netty.util.concurrent.SingleThreadEventExecutor.reject(SingleThreadEventExecutor.java:934)
	at io.netty.util.concurrent.SingleThreadEventExecutor.offerTask(SingleThreadEventExecutor.java:353)
	at io.netty.util.concurrent.SingleThreadEventExecutor.addTask(SingleThreadEventExecutor.java:346)
	at io.netty.util.concurrent.SingleThreadEventExecutor.execute(SingleThreadEventExecutor.java:836)
	at io.netty.util.concurrent.SingleThreadEventExecutor.execute0(SingleThreadEventExecutor.java:827)
	at io.netty.util.concurrent.SingleThreadEventExecutor.execute(SingleThreadEventExecutor.java:817)
	at io.vertx.core.impl.EventLoopExecutor.execute(EventLoopExecutor.java:35)

⚙️ Maven Tests - JDK 17

📦 integration-tests/maven

io.quarkus.maven.it.ImageBuildIT.testImageBuildWithJib - History

  • expected: 0 but was: 1 - org.opentest4j.AssertionFailedError
org.opentest4j.AssertionFailedError: 

expected: 0
 but was: 1
	at io.quarkus.maven.it.ImageBuildIT.testImageBuildWithJib(ImageBuildIT.java:33)
	at java.base/java.lang.reflect.Method.invoke(Method.java:569)
	at java.base/java.util.ArrayList.forEach(ArrayList.java:1511)
	at java.base/java.util.ArrayList.forEach(ArrayList.java:1511)

io.quarkus.maven.it.ImageBuildIT.testImageBuildWithJib - History

  • expected: 0 but was: 1 - org.opentest4j.AssertionFailedError
org.opentest4j.AssertionFailedError: 

expected: 0
 but was: 1
	at io.quarkus.maven.it.ImageBuildIT.testImageBuildWithJib(ImageBuildIT.java:33)
	at java.base/java.lang.reflect.Method.invoke(Method.java:569)
	at java.base/java.util.ArrayList.forEach(ArrayList.java:1511)
	at java.base/java.util.ArrayList.forEach(ArrayList.java:1511)

@gsmet gsmet merged commit 02377d5 into quarkusio:main Mar 14, 2025
56 checks passed
@quarkus-bot quarkus-bot bot removed the triage/waiting-for-ci Ready to merge when CI successfully finishes label Mar 14, 2025
@quarkus-bot quarkus-bot bot added this to the 3.22 - main milestone Mar 14, 2025
@gsmet gsmet modified the milestones: 3.22 - main, 3.21.0 Mar 18, 2025
@gsmet gsmet modified the milestones: 3.21.0, 3.19.4 Mar 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants