-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Warn if using old @ConfigRoot class configuration mechanism #46314
Conversation
This comment has been minimized.
This comment has been minimized.
|
||
if (configRoot.getAnnotation(Deprecated.class) == null) { | ||
log.warn(configRoot.getName() | ||
+ " is considered legacy and should be moved to use an interface and @ConfigMapping"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would be nice to have an URL to explain why and how to do that:
+ " is considered legacy and should be moved to use an interface and @ConfigMapping"); | |
+ " is considered legacy and should be moved to use an interface and @ConfigMapping. See https://quarkus.io/guides/config-mappings for more info"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, the message needs some tweaking, I will have a look soon.
It might be a bit too early to push it anyway.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pending minor adjustments.
|
||
if (configRoot.getAnnotation(Deprecated.class) == null) { | ||
log.warn(configRoot.getName() | ||
+ " is considered legacy and should be moved to use an interface and @ConfigMapping"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, the message needs some tweaking, I will have a look soon.
It might be a bit too early to push it anyway.
Also only display one warning for all configuration roots.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I improved things a little bit, it should be good to go now.
Status for workflow
|
No description provided.