REST Client - Avoid creating a field for NOOP HeaderFiller #46227
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
And move the HeaderFiller to a static field as from what I can see, it's never dependent of the current invocation.
Status for workflow
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
And move the HeaderFiller to a static field as from what I can see, it's never dependent of the current invocation.
It should make the REST Client calls a bit more efficient and also the bytecode as we won't create a field in the most common case of having a NOOP.
It won't make a huge difference but it's free so why not...
@geoand I would appreciate you having a look at this one - mostly the move to static. I have checked the code and I see no reason why this wouldn't be something static, given we just create a new instance of this thing.
I noticed that while having a closer look at #45631 .