Grpc netty client improvements

[franz1981]

Fixes #46148

[quarkus-bot]

Thanks for your pull request!

Your pull request does not follow our editorial rules. Could you have a look?

• description should not be empty, describe your intent or provide links to the issues this PR is fixing (using Fixes #NNNNN) or changelogs

_{This message is automatically generated by a bot.}

[franz1981]

@alesj I think I broke internet here eheh

[franz1981]

I will check the failures tomorrow but I see @cescoffier told in the related issue

When using gRPC Java, we definitely need to avoid reusing the same event loops (we could add this as an option)

Grpc Netty should be safe (in theory?) - or you meant the grpc Java netty provider too?

[franz1981]

Interesting: see

java.lang.IllegalStateException: Both EventLoopGroup and ChannelType should be provided or neither should be

Which means that we have to know how vertx transport is configured and reuse it to configure the grpc Netty channel (nio/epoll/ whatever) in order to work, which kind of make Sense since Netty will complain the same If the event loop used isn't of the "right type" - a limit which have lifted on Netty 4.2 (partially)

[franz1981]

that looks better @alesj wdyt?

[franz1981]

@cescoffier @geoand do we want a special config to enable this?

[geoand]

Probably makes sense

[cescoffier]

Good question. I would say yes and enable it by default. Someone can roll back to the previous behavior if something goes wrong.

[franz1981]

@cescoffier I'll make it a proper runtime config? Documented? wdyt? 🙏

[cescoffier]

@franz1981 Yes, runtime config would be great!

[franz1981]

need some help @cescoffier and @alesj 👍
I see that we create the grpc producer (and the new code I've built) at build time via

quarkus/extensions/grpc/deployment/src/main/java/io/quarkus/grpc/deployment/GrpcClientProcessor.java

Line 474 in de910cc

ResultHandle result = mc.invokeStaticMethod(CREATE_CHANNEL_METHOD, name, interceptorsSet);

but it won't pass runtime properties: how i can pass them?
The other problem is that I keep on reading the sysprop re reusing buffers with it, while I probably just read it once.

[alesj]

Why do you need them at runtime? … and build time is not good enough …

…

On Wed, 19 Feb 2025 at 12:23, Francesco Nigro ***@***.***> wrote: need some help @cescoffier <https://github.com/cescoffier> and @alesj <https://github.com/alesj> 👍 I see that we create the grpc producer at build time via https://github.com/quarkusio/quarkus/blob/de910cc94e9791368fc0ec5663a7d18f44fa61db/extensions/grpc/deployment/src/main/java/io/quarkus/grpc/deployment/GrpcClientProcessor.java#L474 but it won't pass runtime properties: how i can pass them? — Reply to this email directly, view it on GitHub <#46198 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AACRA6DEIGVYQO24ROJSC6L2QRSULAVCNFSM6AAAAABW5ICTACVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDMNRYGM2TCMRSG4> . You are receiving this because you were mentioned.Message ID: ***@***.***> [image: franz1981]*franz1981* left a comment (quarkusio/quarkus#46198) <#46198 (comment)> need some help @cescoffier <https://github.com/cescoffier> and @alesj <https://github.com/alesj> 👍 I see that we create the grpc producer at build time via https://github.com/quarkusio/quarkus/blob/de910cc94e9791368fc0ec5663a7d18f44fa61db/extensions/grpc/deployment/src/main/java/io/quarkus/grpc/deployment/GrpcClientProcessor.java#L474 but it won't pass runtime properties: how i can pass them? — Reply to this email directly, view it on GitHub <#46198 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AACRA6DEIGVYQO24ROJSC6L2QRSULAVCNFSM6AAAAABW5ICTACVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDMNRYGM2TCMRSG4> . You are receiving this because you were mentioned.Message ID: ***@***.***>

[alesj]

You can pass (your modified) GrpcClientBuildTimeConfig to generateGrpcClientProducers ... and then to generateChannelProducer ...

[franz1981]

@alesj @cescoffier I've added the option to use a runtime config instead, to keep it more flexible - since the loaded classes will basically the same

[github-actions]

🎊 PR Preview 58ff745 has been successfully built and deployed to https://quarkus-pr-main-46198-preview.surge.sh/version/main/guides/

• Images of blog posts older than 3 months are not available.
• Newsletters older than 3 months are not available.

[franz1981]

ready to go @cescoffier ? wdyt?

[quarkus-bot]

Status for workflow Quarkus Documentation CI

This is the status report for running Quarkus Documentation CI on commit bf12ff2.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

Warning

There are other workflow runs running, you probably need to wait for their status before merging.

[quarkus-bot]

Status for workflow Quarkus CI

This is the status report for running Quarkus CI on commit bf12ff2.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

You can consult the Develocity build scans.