Integration tests for hibernate-reactive-oracle

[IvanPetkov23]

Added tests for Hibernate Reactive with Oracle. Fixes: #23820

[yrodiere]

Thanks! Looking great, I just have a few comments. The main one being about CI and native tests.

[yrodiere]

Some comments to make the build pass on Windows -- which doesn't have containers and thus cannot handle DB tests.
Essentially these tests need to be disabled by default, like in every other module, and enabled when passing -Dtest-containers to Maven.

[IvanPetkov23]

I am sorry about the merge commits in the PR, but I am new to open source, so I am still learning :)

[yrodiere]

I am sorry about the merge commits in the PR, but I am new to open source, so I am still learning :)

No problem. You may want to learn about rebasing: https://docs.github.com/en/get-started/using-git/about-git-rebase

If you rebase your branch on main, you should be able to get rid of merge commits. Typically I use git rebase -i main, but I'd recommend you read the GitHub docs by following the link above :)

[IvanPetkov23]

It is getting worse, so I converted the PR to draft :)

[yrodiere]

Do you need me to do the rebase, or are you still trying? :)

[IvanPetkov23]

I am still trying, but without success. If you can do it for me, that would be great! :)

[yrodiere]

On it

[yrodiere]

Alright, I force-pushed a rebase.

I must admit you got yourself in quite a situation 😅 Better avoid merge commits from the start, next time :) You can instruct git to rebase by default when pulling, instead of merging: https://coderwall.com/p/tnoiug/rebase-by-default-when-doing-git-pull

FWIW, here's what I did:

git switch main
git pull
git switch <your branch>
git rebase -i main

I used "s" for every commit to squash everything:

Got a conflict:

Auto-merging .github/native-tests.json
CONFLICT (content): Merge conflict in .github/native-tests.json
error: could not apply 43df92f39ea... Fix git issues
hint: Resolve all conflicts manually, mark them as resolved with
hint: "git add/rm <conflicted_files>", then run "git rebase --continue".
hint: You can instead skip this commit: run "git rebase --skip".
hint: To abort and get back to the state before "git rebase", run "git rebase --abort".
hint: Disable this message with "git config set advice.mergeConflict false"
Recorded preimage for '.github/native-tests.json'
Could not apply 43df92f39ea... Fix git issues

Solved it manually in my IDE, then:

git add -A
git rebase --continue

Got another conflict:

Auto-merging integration-tests/hibernate-reactive-oracle/pom.xml
CONFLICT (add/add): Merge conflict in integration-tests/hibernate-reactive-oracle/pom.xml
error: could not apply 4a8813cfe65... Updated native-tests.json to support hibernate-reactive-oracle module. Refactored pom.xml to pass build on windows.
hint: Resolve all conflicts manually, mark them as resolved with
hint: "git add/rm <conflicted_files>", then run "git rebase --continue".
hint: You can instead skip this commit: run "git rebase --skip".
hint: To abort and get back to the state before "git rebase", run "git rebase --abort".
hint: Disable this message with "git config set advice.mergeConflict false"
Recorded preimage for 'integration-tests/hibernate-reactive-oracle/pom.xml'
Could not apply 4a8813cfe65... Updated native-tests.json to support hibernate-reactive-oracle module. Refactored pom.xml to pass build on windows.

Solved it manually in my IDE, then:

git add -A
git rebase --continue

Got another conflict:

CONFLICT (content): Merge conflict in .github/native-tests.json
Auto-merging integration-tests/hibernate-reactive-oracle/pom.xml
CONFLICT (content): Merge conflict in integration-tests/hibernate-reactive-oracle/pom.xml
error: could not apply b702df5da95... Updated native-tests.json to support hibernate-reactive-oracle module. Refactored pom.xml to pass build on windows.
hint: Resolve all conflicts manually, mark them as resolved with
hint: "git add/rm <conflicted_files>", then run "git rebase --continue".
hint: You can instead skip this commit: run "git rebase --skip".
hint: To abort and get back to the state before "git rebase", run "git rebase --abort".
hint: Disable this message with "git config set advice.mergeConflict false"
Recorded preimage for '.github/native-tests.json'
Recorded preimage for 'integration-tests/hibernate-reactive-oracle/pom.xml'
Could not apply b702df5da95... Updated native-tests.json to support hibernate-reactive-oracle module. Refactored pom.xml to pass build on windows.

Solved it manually in my IDE, then:

git add -A
git rebase --continue

Then rebase ended successfully, so I force-pushed to rewrite the git history of this branch (don't do this anywhere, but for PRs with a messy history, it's reasonable):

git push --force

[yrodiere]

@IvanPetkov23 I think this should have been updated to reactive-oracle.url to match your other changes.

CI is failing because it wasn't.

[IvanPetkov23]

Thanks for the help and the patience :)

[yrodiere]

I added a commit to fix the DB setup, because it didn't work. Also rebased on main.

It works locally, let's see how it goes on CI.

[IvanPetkov23]

It is working locally on my machine too. Why CI tests are failing?

[yrodiere]

I believe something leaves the Oracle container running after the new hibernate-reactive-oracle integration tests run, leading to problems when running later integration tests.
I can't investigate now, but will have a look, most likely next week :/

[quarkus-bot]

Status for workflow Quarkus CI

This is the status report for running Quarkus CI on commit a6dadc5.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

You can consult the Develocity build scans.

---

Flaky tests - Develocity

⚙️ JVM Tests - JDK 17 Windows

📦 extensions/micrometer-opentelemetry/deployment

✖ io.quarkus.micrometer.opentelemetry.deployment.compatibility.MicrometerTimedInterceptorTest.testTimeMethod_Uni - History

• Stream has no elements - java.lang.IllegalArgumentException

java.lang.IllegalArgumentException: Stream has no elements
	at io.quarkus.micrometer.opentelemetry.deployment.common.MetricDataFilter.lambda$lastReading$2(MetricDataFilter.java:213)
	at java.base/java.util.Optional.orElseThrow(Optional.java:403)
	at io.quarkus.micrometer.opentelemetry.deployment.common.MetricDataFilter.lastReading(MetricDataFilter.java:213)
	at io.quarkus.micrometer.opentelemetry.deployment.common.MetricDataFilter.lastReadingDataPoint(MetricDataFilter.java:231)
	at io.quarkus.micrometer.opentelemetry.deployment.compatibility.MicrometerTimedInterceptorTest.testTimeMethod_Uni(MicrometerTimedInterceptorTest.java:174)
	at java.base/java.lang.reflect.Method.invoke(Method.java:569)
	at io.quarkus.test.QuarkusUnitTest.runExtensionMethod(QuarkusUnitTest.java:521)

[yrodiere]

Looks like the failures were caused by problems on the main branch; rebasing today fixed them.

We're good to go, I'll merge. Thanks again @IvanPetkov23!