Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Docs: Create and update S2I procedures for the Deploying on OpenShift guide #45954

Merged
merged 1 commit into from
Mar 14, 2025
Merged

Docs: Create and update S2I procedures for the Deploying on OpenShift guide #45954

merged 1 commit into from
Mar 14, 2025
+239 −0

Conversation

sheilamjones
Copy link
Contributor

@sheilamjones sheilamjones commented Jan 29, 2025 •
edited
Loading

This PR aims to draft a procedure for the following use case:

  • Using S2I to deploy Red Hat build of Quarkus applications to OpenShift based on downstream guide:

Reference: Using S2I to deploy on OpenShift

@sheilamjones sheilamjones marked this pull request as draft January 29, 2025 15:03
@quarkus-bot quarkus-bot bot added area/docstyle issues related for manual docstyle review area/documentation labels Jan 29, 2025
@sheilamjones sheilamjones force-pushed the QDOCS-1062-S2I branch 3 times, most recently from a9bb223 to 590b096 Compare February 7, 2025 12:42
@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 7, 2025 •
edited
Loading

🙈 The PR is closed and the preview is expired.

@sheilamjones sheilamjones marked this pull request as ready for review February 7, 2025 13:29
rolfedh
rolfedh reviewed Feb 7, 2025
View reviewed changes
Copy link
Contributor

@rolfedh rolfedh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent work, @sheilamjones. Thanks for bringing this valuable content upstream. I've offered some suggestions for clarity and consistency. Feel free to adapt as you see fit.

@quarkus-bot quarkus-bot

This comment has been minimized.

Sign in to view
sheilamjones
sheilamjones commented Feb 13, 2025
View reviewed changes
docs/src/main/asciidoc/deploying-to-openshift-S2I-howto.adoc

[IMPORTANT]
====
S2I is not supported for native deployments.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not relevant for upstream. It works upstream, but support not provided for it downstream.

@quarkus-bot quarkus-bot

This comment has been minimized.

Sign in to view
@quarkus-bot quarkus-bot

This comment has been minimized.

Sign in to view
@quarkus-bot quarkus-bot

This comment has been minimized.

Sign in to view
iocanel
iocanel approved these changes Mar 13, 2025
View reviewed changes
Copy link
Contributor

@iocanel iocanel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have left a minor suggestion, but I am OK with merging as is.

@sheilamjones
Copy link
Contributor Author

Many thanks @iocanel for your review. Can you please advise what your comment is as I don't see it in the PR. I have resolved that outstanding one from Rolfe.
Thank you.

@quarkus-bot quarkus-bot

This comment has been minimized.

Sign in to view
@gsmet gsmet added triage/backport-3.20 triage/waiting-for-ci Ready to merge when CI successfully finishes labels Mar 13, 2025
@gsmet
Copy link
Member

gsmet commented Mar 13, 2025

I squashed the commits and will merge tomorrow morning when CI is green.

@quarkus-bot quarkus-bot
Copy link

quarkus-bot bot commented Mar 13, 2025

Status for workflow Quarkus Documentation CI

This is the status report for running Quarkus Documentation CI on commit 5b4f9e3.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

@gsmet gsmet merged commit 0b3e820 into quarkusio:main Mar 14, 2025
5 checks passed
@quarkus-bot quarkus-bot bot removed the triage/waiting-for-ci Ready to merge when CI successfully finishes label Mar 14, 2025
@quarkus-bot quarkus-bot bot added this to the 3.22 - main milestone Mar 14, 2025
@sheilamjones sheilamjones mentioned this pull request Mar 18, 2025
Merged
@gsmet gsmet modified the milestones: 3.22 - main, 3.21.0 Mar 18, 2025
@gsmet gsmet modified the milestones: 3.21.0, 3.19.4 Mar 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rolfedh rolfedh rolfedh left review comments

@iocanel iocanel iocanel approved these changes

Assignees
No one assigned
Labels
area/docstyle issues related for manual docstyle review area/documentation
Projects
None yet
Milestone
3.19.4
Development

Successfully merging this pull request may close these issues.
4 participants
@sheilamjones @gsmet @rolfedh @iocanel