Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove erroneous state tracking from client readers/writers #45518

Merged
merged 1 commit into from
Jan 13, 2025
Merged

Remove erroneous state tracking from client readers/writers #45518

merged 1 commit into from
Jan 13, 2025

Conversation

geoand
Copy link
Contributor

@geoand geoand commented Jan 11, 2025 •
edited by gsmet
Loading

MessageBodyReader and MessageBodyWriter are effectively singletons and should not have state

@quarkus-bot quarkus-bot

This comment was marked as resolved.

Sign in to view
@geoand geoand mentioned this pull request Jan 13, 2025
Open
@geoand geoand marked this pull request as ready for review January 13, 2025 09:41
@geoand geoand requested a review from gsmet January 13, 2025 09:42
@gsmet
Copy link
Member

gsmet commented Jan 13, 2025

Thanks! I'll have a look later today.

@geoand
Copy link
Contributor Author

geoand commented Jan 13, 2025

🙏🏽

@quarkus-bot quarkus-bot
Copy link

quarkus-bot bot commented Jan 13, 2025 •
edited by github-actions bot
Loading

Status for workflow Quarkus CI

This is the status report for running Quarkus CI on commit cae6630.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

You can consult the Develocity build scans.

@gsmet gsmet merged commit fec4b02 into quarkusio:main Jan 13, 2025
47 checks passed
@quarkus-bot quarkus-bot bot added this to the 3.18 - main milestone Jan 13, 2025
@geoand geoand deleted the rest-client-memory branch January 13, 2025 15:37
@gsmet gsmet modified the milestones: 3.18 - main, 3.17.7 Jan 14, 2025
@lasteris lasteris mentioned this pull request Jan 14, 2025
Closed
@jmartisk jmartisk modified the milestones: 3.17.7, 3.15.4 Feb 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gsmet gsmet gsmet approved these changes

Assignees
No one assigned
Labels
area/rest
Projects
None yet
Milestone
3.15.4
Development

Successfully merging this pull request may close these issues.
3 participants
@geoand @gsmet @jmartisk