Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Qute message bundles: fix localization of enums #44883

Merged
merged 1 commit into from
Dec 3, 2024

Conversation

mkouba
Copy link
Contributor

@mkouba mkouba commented Dec 3, 2024

Copy link

github-actions bot commented Dec 3, 2024

🙈 The PR is closed and the preview is expired.

This comment has been minimized.

This comment has been minimized.

- support constants with underscores
- fixes quarkusio#44866
Copy link

quarkus-bot bot commented Dec 3, 2024

Status for workflow Quarkus CI

This is the status report for running Quarkus CI on commit b322dbf.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

Warning

There are other workflow runs running, you probably need to wait for their status before merging.

Copy link

quarkus-bot bot commented Dec 3, 2024

Status for workflow Quarkus Documentation CI

This is the status report for running Quarkus Documentation CI on commit b322dbf.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

@gastaldi gastaldi merged commit a21a9e9 into quarkusio:main Dec 3, 2024
25 checks passed
@quarkus-bot quarkus-bot bot added this to the 3.18 - main milestone Dec 3, 2024
@gsmet gsmet modified the milestones: 3.18 - main, 3.17.3 Dec 3, 2024
@gsmet
Copy link
Member

gsmet commented Feb 20, 2025

@mkouba we wanted to make sure before backporting to 3.15 this wouldn't break existing applications i.e. if you have a key defined for an enum that was working prior to this patch, it will still be taken into account?

Thanks.

@mkouba
Copy link
Contributor Author

mkouba commented Feb 20, 2025

@mkouba we wanted to make sure before backporting to 3.15 this wouldn't break existing applications i.e. if you have a key defined for an enum that was working prior to this patch, it will still be taken into account?

I think that previously if a message enum key contained _ or $ the build just failed.

@gsmet
Copy link
Member

gsmet commented Feb 24, 2025

@mkouba but if you had keys with enums in your resource bundle that worked before, they will still work, right? That's what we wanted to check.

@mkouba
Copy link
Contributor Author

mkouba commented Feb 24, 2025

@mkouba but if you had keys with enums in your resource bundle that worked before, they will still work, right? That's what we wanted to check.

Yes, they should still work.

@jmartisk jmartisk modified the milestones: 3.17.3, 3.15.4 Feb 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Qute message bundle using enum uppercase with words separated by underscores
4 participants