Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: grep failed when in some special scenario #327

Merged
merged 1 commit into from
Feb 24, 2023

Conversation

CarlJi
Copy link
Collaborator

@CarlJi CarlJi commented Feb 24, 2023

No description provided.

@qiniu-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: CarlJi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@codecov
Copy link

codecov bot commented Feb 24, 2023

Codecov Report

Merging #327 (4c909b6) into master (a3dfbf5) will increase coverage by 0.09%.
The diff coverage is n/a.

❗ Current head 4c909b6 differs from pull request most recent head 3901c0e. Consider uploading reports for the commit 3901c0e to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #327      +/-   ##
==========================================
+ Coverage   70.76%   70.85%   +0.09%     
==========================================
  Files          34       34              
  Lines        2035     2035              
==========================================
+ Hits         1440     1442       +2     
+ Misses        481      480       -1     
+ Partials      114      113       -1     
Flag Coverage Δ
unittest-1.16.x 70.76% <ø> (+0.09%) ⬆️
unittest-1.17.x 70.76% <ø> (ø)
unittest-1.18.x 70.76% <ø> (+0.09%) ⬆️
unittest-1.19.x 70.76% <ø> (+0.09%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/build/legacy.go 100.00% <0.00%> (+4.87%) ⬆️

@CarlJi CarlJi merged commit ebd813c into qiniu:master Feb 24, 2023
@CarlJi CarlJi deleted the bug_fix branch February 24, 2023 09:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants