-
Notifications
You must be signed in to change notification settings - Fork 123
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix service info err #240
fix service info err #240
Conversation
pkg/cover/server.go
Outdated
@@ -174,14 +174,14 @@ func (s *server) profile(c *gin.Context) { | |||
|
|||
var mergedProfiles = make([][]*cover.Profile, 0) | |||
for _, addr := range filterAddrList { | |||
pp, err := NewWorker(addr).Profile(ProfileParam{}) | |||
pp, err := NewWorker(addr.Address).Profile(ProfileParam{}) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
filterAddrList 和 addr 两个变量可以换了。这里 addr 不再单是地址的含义了。
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
updated
b6242ed
to
00f503b
Compare
fix add fix var fix service info err
00f503b
to
b54ac9e
Compare
Codecov Report
@@ Coverage Diff @@
## master #240 +/- ##
==========================================
- Coverage 71.25% 71.20% -0.05%
==========================================
Files 34 34
Lines 2007 2011 +4
==========================================
+ Hits 1430 1432 +2
Misses 471 471
- Partials 106 108 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: lyyyuna, xwen-winnie The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
背景
https://prow.qiniu.io/view/qn/carl-prow-artifacts/pr-logs/pull/qbox_kodo/4183/kodo-pull-integration-test/1452452703476125696/
当前若有服务挂掉或者超时,打印日志看出来具体服务信息