Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix service info err #240

Merged
merged 1 commit into from
Oct 26, 2021
Merged

fix service info err #240

merged 1 commit into from
Oct 26, 2021

Conversation

xwen-winnie
Copy link
Contributor

@xwen-winnie xwen-winnie commented Oct 25, 2021

背景
https://prow.qiniu.io/view/qn/carl-prow-artifacts/pr-logs/pull/qbox_kodo/4183/kodo-pull-integration-test/1452452703476125696/
当前若有服务挂掉或者超时,打印日志看出来具体服务信息

@@ -174,14 +174,14 @@ func (s *server) profile(c *gin.Context) {

var mergedProfiles = make([][]*cover.Profile, 0)
for _, addr := range filterAddrList {
pp, err := NewWorker(addr).Profile(ProfileParam{})
pp, err := NewWorker(addr.Address).Profile(ProfileParam{})
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

filterAddrList 和 addr 两个变量可以换了。这里 addr 不再单是地址的含义了。

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated

@xwen-winnie xwen-winnie force-pushed the addserviceinfo branch 3 times, most recently from b6242ed to 00f503b Compare October 26, 2021 02:41
fix add

fix var

fix service info err
@codecov
Copy link

codecov bot commented Oct 26, 2021

Codecov Report

Merging #240 (6970541) into master (99a9075) will decrease coverage by 0.04%.
The diff coverage is 85.71%.

❗ Current head 6970541 differs from pull request most recent head b54ac9e. Consider uploading reports for the commit b54ac9e to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master     #240      +/-   ##
==========================================
- Coverage   71.25%   71.20%   -0.05%     
==========================================
  Files          34       34              
  Lines        2007     2011       +4     
==========================================
+ Hits         1430     1432       +2     
  Misses        471      471              
- Partials      106      108       +2     
Flag Coverage Δ
e2e-1.11.x ∅ <ø> (∅)
e2e-1.12.x ∅ <ø> (∅)
e2e-1.13.x ∅ <ø> (∅)
e2e-1.14.x ∅ <ø> (∅)
e2e-1.15.x ∅ <ø> (∅)
e2e-1.16.x ∅ <ø> (∅)
unittest-1.13.x 71.10% <85.71%> (-0.05%) ⬇️
unittest-1.14.x 71.10% <85.71%> (-0.05%) ⬇️
unittest-1.15.x 71.10% <85.71%> (-0.05%) ⬇️
unittest-1.16.x 71.20% <85.71%> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/build/gomodules.go 94.59% <0.00%> (+0.30%) ⬆️
pkg/cover/server.go 85.78% <94.73%> (+0.14%) ⬆️
pkg/build/legacy.go 95.12% <0.00%> (-4.88%) ⬇️

@qiniu-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lyyyuna, xwen-winnie

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@lyyyuna lyyyuna merged commit 4b501e1 into qiniu:master Oct 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants