-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Zurich tii1qs_xld1000 #121
Conversation
for more information, see https://pre-commit.ci
Improve:
Check:
|
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
@igres26 @stavros11 @andrea-pasquale do you have any idea if we should close this PRs for the 1q or merge them with different names for each set of instruments ? |
I would wait for the lab to decide what will happen to this chip. We should try to keep only platforms that exist in the lab in main, so if they warm up I would close all PRs. @alecandido @andrea-pasquale let us know if you agree. Since this is a PR, I think it is possible to recover the state of the code at any point if needed by checking out the latest commit hash. This works even if the PR is closed and the branch is removed from GitHub. |
I also agree with @stavros11. In |
I agree that only the working platforms should be front and center in main. Maybe a good compromise is to have an "inactive" folder in main where we dump these platforms that could technically come back up. Also for ease of access of the platform files in order to build similar platforms in the future. |
As far as Fred told me they want to have another run next week on the same chip. Let's keep for next week and close it after it. Just wanted to know in case I needed to tidy the platform file or not. |
I could also store report as they will contain the parameters, not the platform though and some plots on how stuff should look like if we were to use that chip again. I would select some reports from this chip. |
Since in the end we did not repeat the benchmarks we can close this. I will create some issues for some of the things I found. |
WIP.