Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add emulator support for fake integrated acquisition #910

Merged
merged 2 commits into from
May 31, 2024

Conversation

sorewachigauyo
Copy link
Contributor

As discussed in the Qibo meeting, I have added the option to use IntegratedResults from the results so that we can run other Qibocal routines. I have done some testing for T1 sequences, but because of the sampling rate boost, it takes a long while to complete.

image

Checklist:

  • Reviewers confirm new code works as expected.
  • Tests are passing.
  • Coverage does not decrease.
  • Documentation is updated.

Copy link

codecov bot commented May 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.09%. Comparing base (10b9247) to head (09635df).

Additional details and impacted files
@@            Coverage Diff            @@
##           emulator     #910   +/-   ##
=========================================
  Coverage     70.08%   70.09%           
=========================================
  Files            61       61           
  Lines          6609     6611    +2     
=========================================
+ Hits           4632     4634    +2     
  Misses         1977     1977           
Flag Coverage Δ
unittests 70.09% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@jykhoo1987 jykhoo1987 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am ok with the changes. Just to clarify, how does the output make sense if the data used for initialization is a list of 0s or 1s instead of a list of complex voltage values?

@sorewachigauyo
Copy link
Contributor Author

In the complex plane, the result will be either 0 (at the center) or 1 (in the real axis). As long as there is a distinction of these two (states), it is possible to distinguish these two. The average magnitude just maps the result to a point between the two states values [0, 1] on the real axis.

@jykhoo1987
Copy link
Contributor

In the complex plane, the result will be either 0 (at the center) or 1 (in the real axis). As long as there is a distinction of these two (states), it is possible to distinguish these two. The average magnitude just maps the result to a point between the two states values [0, 1] on the real axis.

I see, so in this case we just have the idealized results, a perfect readout so to speak.

@jykhoo1987 jykhoo1987 mentioned this pull request May 30, 2024
6 tasks
@jykhoo1987 jykhoo1987 merged commit ddf6f06 into emulator May 31, 2024
35 checks passed
@jykhoo1987 jykhoo1987 deleted the emulator_readout branch May 31, 2024 04:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants