Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

QM disconnection issues #839

Merged
merged 3 commits into from
Mar 19, 2024
Merged

QM disconnection issues #839

merged 3 commits into from
Mar 19, 2024

Conversation

stavros11
Copy link
Member

Fixes two small issues with QM:

  1. instrument.connect() has a small bug (never sets self.is_connected) which causes instrument.disconnect() to not work properly and thus Quantum Machines are never closed. This causes the offsets (for example in flux) to stay on forever, potentially heating the fridge.
  2. Unrelated to the above: a hot fix on duration sweeps of baked pulses. This is temporary (as you know, I am hoping to simplify these kinds of sweeps in 0.2), but it makes the two-qubit chevron routine run a bit better so it would be good to have for now.

@stavros11 stavros11 requested review from alecandido and hay-k March 18, 2024 12:47
@stavros11 stavros11 added the qm label Mar 18, 2024
Copy link

codecov bot commented Mar 18, 2024

Codecov Report

Attention: Patch coverage is 11.11111% with 8 lines in your changes are missing coverage. Please review.

Project coverage is 66.45%. Comparing base (0bd68b0) to head (fc98cf2).

Files Patch % Lines
src/qibolab/instruments/qm/sweepers.py 14.28% 6 Missing ⚠️
src/qibolab/instruments/qm/controller.py 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #839      +/-   ##
==========================================
- Coverage   66.57%   66.45%   -0.13%     
==========================================
  Files          50       50              
  Lines        6079     6081       +2     
==========================================
- Hits         4047     4041       -6     
- Misses       2032     2040       +8     
Flag Coverage Δ
unittests 66.45% <11.11%> (-0.13%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@alecandido alecandido left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nothing to amend to the code itself. I didn't test it (but I expect you did)

@stavros11
Copy link
Member Author

Nothing to amend to the code itself. I didn't test it (but I expect you did)

In fact, I discovered the first issue when one of the controllers was connected to an ammeter in the lab, so it is certainly tested.

@stavros11 stavros11 merged commit 926104e into main Mar 19, 2024
25 of 26 checks passed
@stavros11 stavros11 deleted the qmfixes branch March 19, 2024 08:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants