fetch justification every minute #2344
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: turuslan <[email protected]>
kamilsa
approved these changes
Jan 21, 2025
Co-authored-by: kamilsa <[email protected]>
Signed-off-by: turuslan <[email protected]>
xDimon
approved these changes
Jan 22, 2025
| } | ||
|
|
||
| // If no suitable peers were found, add all connected peers to the list | ||
| if (peers.empty()) { |
There was a problem hiding this comment.
PeerIds of connected peers should be contained in peer repository, isn't it? This addition looks redundant.
There was a problem hiding this comment.
First loop iterates ProtocolRepository and filters peers which have both connection and protocol.
First loop may return zero peers.
Second loop iterates ConnectionManager to get all connected peers.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Referenced issues
Description of the Change
Possible Drawbacks