Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce candidates storing time #2278

Merged
merged 9 commits into from
Nov 23, 2024
Merged

Conversation

kamilsa
Copy link
Contributor

@kamilsa kamilsa commented Nov 19, 2024

Referenced issues

Closes #2276

Description of the Change

Storing candidates in availability store might lead to OOM in Kusama. This PR attempts reducing timeout for storing candidates improves situation.
In addition candidates will be removed whenever corresponding relay chain blocks are finalized.
It is safe to keep candidates for shorter period as after merging #2271 we are going to store them in db for 25 hours anyway

Possible Drawbacks

None

Checklist Before Opening a PR

Before you open a Pull Request (PR), please make sure you've completed the following steps and confirm by answering 'Yes' to each item:

  1. Code is formatted: Have you run your code through clang-format to ensure it adheres to the project's coding standards? Yes
  2. Code is documented: Have you added comments and documentation to your code according to the guidelines in the project's contributing guidelines? Yes
  3. Self-review: Have you reviewed your own code to ensure it is free of typos, syntax errors, logical errors, and unresolved TODOs or FIXME without linking to an issue? Yes
  4. Zombienet Tests: Have you ensured that the zombienet tests are passing? Zombienet is a network simulation and testing tool used in this project. It's important to ensure that these tests pass to maintain the stability and reliability of the project. Not yet

@kamilsa kamilsa requested review from iceseer and ErakhtinB and removed request for iceseer November 20, 2024 13:23
@kamilsa kamilsa marked this pull request as ready for review November 20, 2024 13:23
@kamilsa kamilsa changed the title Reduce candidates timeout to 1min Reduce candidates storing time Nov 20, 2024

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
@kamilsa kamilsa enabled auto-merge (squash) November 23, 2024 13:26
@kamilsa kamilsa merged commit a68a08a into master Nov 23, 2024
12 checks passed
@kamilsa kamilsa deleted the fix/reduce-candidates-timeout branch November 23, 2024 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Validator regularly OOMs on Kusama
3 participants