candidates_pending_availability added

[ErakhtinB]

Referenced issues

Description of the Change

Possible Drawbacks

Checklist Before Opening a PR

Before you open a Pull Request (PR), please make sure you've completed the following steps and confirm by answering 'Yes' to each item:

1. Code is formatted: Have you run your code through clang-format to ensure it adheres to the project's coding standards? [Yes|No]
2. Code is documented: Have you added comments and documentation to your code according to the guidelines in the project's contributing guidelines? [Yes|No]
3. Self-review: Have you reviewed your own code to ensure it is free of typos, syntax errors, logical errors, and unresolved TODOs or FIXME without linking to an issue? [Yes|No]
4. Zombienet Tests: Have you ensured that the zombienet tests are passing? Zombienet is a network simulation and testing tool used in this project. It's important to ensure that these tests pass to maintain the stability and reliability of the project. [Yes|No]

[Harrm]

Why is it disabled?

[ErakhtinB]

Every test in this file is disabled

[Harrm]

But why?

[Harrm]

Is the copy eliminated here/how large can this vector be? Maybe construct an outcome::result and move the vector there explicitly to avoid copying, if it can be large?

[ErakhtinB]

Added explicit moving

[Harrm]

return std::move is typically a worse alternative, I mean construct a variable with type exactly matching the result type and move in its constructor, this practically guarantees RVO.

[ErakhtinB]

I think move constructor for return value is guaranteed by this move. outcome::result<std::vector<std::optional>> res = std::move(*ref) is literally what's gonna happen. Anyway the vector will be moved efficiently.