Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/import manifest tests #2238

Merged
merged 64 commits into from
Nov 12, 2024
Merged

Feature/import manifest tests #2238

merged 64 commits into from
Nov 12, 2024

Conversation

iceseer
Copy link
Contributor

@iceseer iceseer commented Oct 11, 2024

Referenced issues

Description of the Change

[test] Added additional tests to verify manifest import process.
[refactor] workflow of statements/manifests processing moved in a separate StatementDistribution class
[fixes] some logical fixes

Possible Drawbacks

Checklist Before Opening a PR

Before you open a Pull Request (PR), please make sure you've completed the following steps and confirm by answering 'Yes' to each item:

  1. Code is formatted: Have you run your code through clang-format to ensure it adheres to the project's coding standards? [Yes|No]
  2. Code is documented: Have you added comments and documentation to your code according to the guidelines in the project's contributing guidelines? [Yes|No]
  3. Self-review: Have you reviewed your own code to ensure it is free of typos, syntax errors, logical errors, and unresolved TODOs or FIXME without linking to an issue? [Yes|No]
  4. Zombienet Tests: Have you ensured that the zombienet tests are passing? Zombienet is a network simulation and testing tool used in this project. It's important to ensure that these tests pass to maintain the stability and reliability of the project. [Yes|No]

Signed-off-by: iceseer <[email protected]>
Signed-off-by: iceseer <[email protected]>
1
Signed-off-by: iceseer <[email protected]>
Signed-off-by: iceseer <[email protected]>
Signed-off-by: iceseer <[email protected]>
Signed-off-by: iceseer <[email protected]>
Signed-off-by: iceseer <[email protected]>
Signed-off-by: iceseer <[email protected]>
Signed-off-by: iceseer <[email protected]>
Signed-off-by: iceseer <[email protected]>
Signed-off-by: iceseer <[email protected]>
Signed-off-by: iceseer <[email protected]>
Signed-off-by: iceseer <[email protected]>
Signed-off-by: iceseer <[email protected]>
Signed-off-by: iceseer <[email protected]>
Signed-off-by: iceseer <[email protected]>
Signed-off-by: iceseer <[email protected]>
Signed-off-by: iceseer <[email protected]>
@iceseer iceseer force-pushed the feature/import_manifest_tests branch from 45458d6 to 40c915d Compare October 22, 2024 13:59
Signed-off-by: iceseer <[email protected]>
Signed-off-by: iceseer <[email protected]>
Signed-off-by: iceseer <[email protected]>
Signed-off-by: iceseer <[email protected]>
Signed-off-by: iceseer <[email protected]>
@iceseer iceseer force-pushed the feature/import_manifest_tests branch from 509a78d to 6d32f0f Compare October 24, 2024 07:18
Signed-off-by: iceseer <[email protected]>
@iceseer iceseer force-pushed the feature/import_manifest_tests branch 2 times, most recently from f6a11fe to 8e06a56 Compare November 5, 2024 21:24
@iceseer iceseer force-pushed the feature/import_manifest_tests branch from 8e06a56 to 0673ef1 Compare November 5, 2024 21:32
…fest_tests

Signed-off-by: iceseer <[email protected]>

# Conflicts:
#	core/parachain/availability/store/store_impl.cpp
Signed-off-by: iceseer <[email protected]>
@iceseer iceseer force-pushed the feature/import_manifest_tests branch from 23d896c to 4a4db6a Compare November 7, 2024 11:40
@iceseer iceseer changed the title Feature/import mafifest tests Feature/import manifest tests Nov 11, 2024
Copy link
Contributor

@igor-egorov igor-egorov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please check review comments

@iceseer iceseer enabled auto-merge (squash) November 12, 2024 06:59
@iceseer iceseer force-pushed the feature/import_manifest_tests branch 3 times, most recently from 79b82c5 to 9d1dec1 Compare November 12, 2024 12:23
Signed-off-by: iceseer <[email protected]>
@iceseer iceseer force-pushed the feature/import_manifest_tests branch from 9d1dec1 to 2afee0f Compare November 12, 2024 13:42
@iceseer iceseer force-pushed the feature/import_manifest_tests branch from e8ddfe4 to fb3729d Compare November 12, 2024 20:32
Signed-off-by: iceseer <[email protected]>
@iceseer iceseer force-pushed the feature/import_manifest_tests branch from fb3729d to a909048 Compare November 12, 2024 21:36
@iceseer iceseer merged commit 1d7f2ee into master Nov 12, 2024
11 of 12 checks passed
@iceseer iceseer deleted the feature/import_manifest_tests branch November 12, 2024 22:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants