-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/import manifest tests #2238
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: iceseer <[email protected]>
Signed-off-by: iceseer <[email protected]>
Signed-off-by: iceseer <[email protected]>
Signed-off-by: iceseer <[email protected]>
Signed-off-by: iceseer <[email protected]>
Signed-off-by: iceseer <[email protected]>
Signed-off-by: iceseer <[email protected]>
Signed-off-by: iceseer <[email protected]>
Signed-off-by: iceseer <[email protected]>
Signed-off-by: iceseer <[email protected]>
Signed-off-by: iceseer <[email protected]>
Signed-off-by: iceseer <[email protected]>
Signed-off-by: iceseer <[email protected]>
Signed-off-by: iceseer <[email protected]>
Signed-off-by: iceseer <[email protected]>
Signed-off-by: iceseer <[email protected]>
Signed-off-by: iceseer <[email protected]>
Signed-off-by: iceseer <[email protected]>
Signed-off-by: iceseer <[email protected]>
Signed-off-by: iceseer <[email protected]>
Signed-off-by: iceseer <[email protected]>
45458d6
to
40c915d
Compare
Signed-off-by: iceseer <[email protected]>
Signed-off-by: iceseer <[email protected]>
Signed-off-by: iceseer <[email protected]>
Signed-off-by: iceseer <[email protected]>
Signed-off-by: iceseer <[email protected]>
509a78d
to
6d32f0f
Compare
Signed-off-by: iceseer <[email protected]>
f6a11fe
to
8e06a56
Compare
Signed-off-by: iceseer <[email protected]>
8e06a56
to
0673ef1
Compare
Signed-off-by: iceseer <[email protected]>
…fest_tests Signed-off-by: iceseer <[email protected]> # Conflicts: # core/parachain/availability/store/store_impl.cpp
This reverts commit 0673ef1.
Signed-off-by: iceseer <[email protected]>
Signed-off-by: iceseer <[email protected]>
23d896c
to
4a4db6a
Compare
Signed-off-by: iceseer <[email protected]>
This reverts commit 4a4db6a.
Signed-off-by: iceseer <[email protected]>
igor-egorov
reviewed
Nov 11, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please check review comments
xDimon
approved these changes
Nov 11, 2024
igor-egorov
approved these changes
Nov 12, 2024
79b82c5
to
9d1dec1
Compare
Signed-off-by: iceseer <[email protected]>
9d1dec1
to
2afee0f
Compare
e8ddfe4
to
fb3729d
Compare
Signed-off-by: iceseer <[email protected]>
fb3729d
to
a909048
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Referenced issues
Description of the Change
[test] Added additional tests to verify manifest import process.
[refactor] workflow of statements/manifests processing moved in a separate
StatementDistribution
class[fixes] some logical fixes
Possible Drawbacks
Checklist Before Opening a PR
Before you open a Pull Request (PR), please make sure you've completed the following steps and confirm by answering 'Yes' to each item: