Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix/utils get ref #2237

Merged
merged 15 commits into from
Oct 10, 2024
Merged

Fix/utils get ref #2237

merged 15 commits into from
Oct 10, 2024

Conversation

iceseer
Copy link
Contributor

@iceseer iceseer commented Oct 10, 2024

Referenced issues

Description of the Change

Possible Drawbacks

Checklist Before Opening a PR

Before you open a Pull Request (PR), please make sure you've completed the following steps and confirm by answering 'Yes' to each item:

  1. Code is formatted: Have you run your code through clang-format to ensure it adheres to the project's coding standards? [Yes|No]
  2. Code is documented: Have you added comments and documentation to your code according to the guidelines in the project's contributing guidelines? [Yes|No]
  3. Self-review: Have you reviewed your own code to ensure it is free of typos, syntax errors, logical errors, and unresolved TODOs or FIXME without linking to an issue? [Yes|No]
  4. Zombienet Tests: Have you ensured that the zombienet tests are passing? Zombienet is a network simulation and testing tool used in this project. It's important to ensure that these tests pass to maintain the stability and reliability of the project. [Yes|No]

iceseer added 15 commits October 9, 2024 18:20
@iceseer
tests
eda7da4 
Signed-off-by: iceseer <[email protected]>
@iceseer
tests
ca9d59c 
Signed-off-by: iceseer <[email protected]>
@iceseer
tests + statement_filter check
8f6f9fb 
Signed-off-by: iceseer <[email protected]>
@iceseer
fixup!
d57b826 
Signed-off-by: iceseer <[email protected]>
@iceseer
formatting
2ccf818 
Signed-off-by: iceseer <[email protected]>
@iceseer
fixup
1cbcc23 
Signed-off-by: iceseer <[email protected]>
@iceseer
tests
80603ee 
Signed-off-by: iceseer <[email protected]>
@iceseer
tests
dbf9ee1 
Signed-off-by: iceseer <[email protected]>
@iceseer
tests
6ce2062 
Signed-off-by: iceseer <[email protected]>
@iceseer
fixup
cbd1e05 
Signed-off-by: iceseer <[email protected]>
@iceseer
tests complete
a91375a 
Signed-off-by: iceseer <[email protected]>
@iceseer
formatting
f9ff468 
Signed-off-by: iceseer <[email protected]>
@iceseer
utils::get ref
f4fca4f 
Signed-off-by: iceseer <[email protected]>
@iceseer
ref
2e86ba9 
Signed-off-by: iceseer <[email protected]>
@iceseer
Merge remote-tracking branch 'origin/master' into fix/utils_get_ref
4d204f7 
Signed-off-by: iceseer <[email protected]>

# Conflicts:
#	core/parachain/backing/grid_tracker.hpp
@iceseer iceseer marked this pull request as ready for review October 10, 2024 07:12
igor-egorov
igor-egorov approved these changes Oct 10, 2024
View reviewed changes
Copy link
Contributor

@igor-egorov igor-egorov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💪

@iceseer iceseer merged commit c2cdc56 into master Oct 10, 2024
13 checks passed
@iceseer iceseer deleted the fix/utils_get_ref branch October 10, 2024 08:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@turuslan turuslan turuslan approved these changes

@igor-egorov igor-egorov igor-egorov approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@iceseer @turuslan @igor-egorov