Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/grid tracker tests and fixes #2235

Merged
merged 12 commits into from
Oct 10, 2024
Merged

Conversation

iceseer
Copy link
Contributor

@iceseer iceseer commented Oct 9, 2024

Referenced issues

Description of the Change

Added set of tests for cluster tracker states.
Fixup incorrect CandidateHash value passed in a backed_confirmed.

Possible Drawbacks

Checklist Before Opening a PR

Before you open a Pull Request (PR), please make sure you've completed the following steps and confirm by answering 'Yes' to each item:

  1. Code is formatted: Have you run your code through clang-format to ensure it adheres to the project's coding standards? Yes
  2. Code is documented: Have you added comments and documentation to your code according to the guidelines in the project's contributing guidelines? Yes
  3. Self-review: Have you reviewed your own code to ensure it is free of typos, syntax errors, logical errors, and unresolved TODOs or FIXME without linking to an issue? Yes - twice
  4. Zombienet Tests: Have you ensured that the zombienet tests are passing? Zombienet is a network simulation and testing tool used in this project. It's important to ensure that these tests pass to maintain the stability and reliability of the project. Yes

Signed-off-by: iceseer <[email protected]>
Signed-off-by: iceseer <[email protected]>
Signed-off-by: iceseer <[email protected]>
Signed-off-by: iceseer <[email protected]>
@iceseer iceseer changed the title Feature/grid tracker tests Feature/grid tracker tests and fixes Oct 9, 2024
Signed-off-by: iceseer <[email protected]>
Signed-off-by: iceseer <[email protected]>
Signed-off-by: iceseer <[email protected]>
Signed-off-by: iceseer <[email protected]>
@iceseer iceseer force-pushed the feature/grid_tracker_tests branch from 0e3e2be to 6ce2062 Compare October 9, 2024 22:02
Signed-off-by: iceseer <[email protected]>
Signed-off-by: iceseer <[email protected]>
Signed-off-by: iceseer <[email protected]>
@iceseer iceseer marked this pull request as ready for review October 10, 2024 05:41
GridTracker::Error::MALFORMED_REMOTE_KNOWLEDGE_LEN);
}

TEST_F(GridTrackerTest, reject_malformed_no_seconders) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing given-when-then test notation but it seems we gave up on this a long time ago.

@iceseer iceseer enabled auto-merge (squash) October 10, 2024 06:17
@iceseer iceseer requested a review from turuslan October 10, 2024 06:20
@iceseer iceseer merged commit 7df54cf into master Oct 10, 2024
13 checks passed
@iceseer iceseer deleted the feature/grid_tracker_tests branch October 10, 2024 06:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants