Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/fragment chain #2207

Merged
merged 73 commits into from
Oct 7, 2024
Merged

Feature/fragment chain #2207

merged 73 commits into from
Oct 7, 2024

Conversation

iceseer
Copy link
Contributor

@iceseer iceseer commented Sep 5, 2024

Referenced issues

Description of the Change

Possible Drawbacks

Checklist Before Opening a PR

Before you open a Pull Request (PR), please make sure you've completed the following steps and confirm by answering 'Yes' to each item:

  1. Code is formatted: Have you run your code through clang-format to ensure it adheres to the project's coding standards? [Yes|No]
  2. Code is documented: Have you added comments and documentation to your code according to the guidelines in the project's contributing guidelines? [Yes|No]
  3. Self-review: Have you reviewed your own code to ensure it is free of typos, syntax errors, logical errors, and unresolved TODOs or FIXME without linking to an issue? [Yes|No]
  4. Zombienet Tests: Have you ensured that the zombienet tests are passing? Zombienet is a network simulation and testing tool used in this project. It's important to ensure that these tests pass to maintain the stability and reliability of the project. [Yes|No]

turuslan and others added 30 commits August 6, 2024 16:47
@turuslan
fix recovery (validators <= discovery_keys)
4db536c 
Signed-off-by: turuslan <[email protected]>
@iceseer
Merge remote-tracking branch 'origin/fix/recovery'
cc3c7b5
@iceseer
backing init fixup
8e599f2 
Signed-off-by: iceseer <[email protected]>
@iceseer
kusama fixup
d85691f 
Signed-off-by: iceseer <[email protected]>
@iceseer
ref
f50664b 
Signed-off-by: iceseer <[email protected]>
@iceseer
candidate storage
09797a0 
Signed-off-by: iceseer <[email protected]>
@iceseer
candidate storage complete
65cc445 
Signed-off-by: iceseer <[email protected]>
@iceseer
candidate storage tests
385c8e8 
Signed-off-by: iceseer <[email protected]>
@iceseer
fragment
e0dc892 
Signed-off-by: iceseer <[email protected]>
@iceseer
constraints
0f0154f 
Signed-off-by: iceseer <[email protected]>
@iceseer
formatting
8d63246 
Signed-off-by: iceseer <[email protected]>
@iceseer
backed chain
cdf198c 
Signed-off-by: iceseer <[email protected]>
@iceseer
scope
479d52e 
Signed-off-by: iceseer <[email protected]>
@iceseer
fragment node
e85a11b 
Signed-off-by: iceseer <[email protected]>
@iceseer
ref
ffd4671 
Signed-off-by: iceseer <[email protected]>
@iceseer
fragment chain
05fe09e 
Signed-off-by: iceseer <[email protected]>
@iceseer
fragment chain
7cef526 
Signed-off-by: iceseer <[email protected]>
@iceseer
fragment chain
220b53b 
Signed-off-by: iceseer <[email protected]>
@iceseer
builded
f53e1f3 
Signed-off-by: iceseer <[email protected]>
@iceseer
scope tests
6bf6efe 
Signed-off-by: iceseer <[email protected]>
@iceseer
fragment chain test
365d7c6 
Signed-off-by: iceseer <[email protected]>
@iceseer
fragment chain test
1dc5b03 
Signed-off-by: iceseer <[email protected]>
@iceseer
fragment chain test
b7e04b9 
Signed-off-by: iceseer <[email protected]>
@iceseer
tests
4e73833 
Signed-off-by: iceseer <[email protected]>
@iceseer
tests
eac0d1f 
Signed-off-by: iceseer <[email protected]>
@iceseer
tests
7d0314e 
Signed-off-by: iceseer <[email protected]>
@iceseer
tests
9c7b335 
Signed-off-by: iceseer <[email protected]>
@iceseer
tests
7fc4165 
Signed-off-by: iceseer <[email protected]>
@iceseer
tests
c673f58 
Signed-off-by: iceseer <[email protected]>
@iceseer
tests
c372629 
Signed-off-by: iceseer <[email protected]>
@iceseer
print logs
80e988c 
Signed-off-by: iceseer <[email protected]>
@iceseer
PATCH FOR APPROVAL
7bb1cfb 
Signed-off-by: iceseer <[email protected]>
@iceseer
tests
237cdba 
Signed-off-by: iceseer <[email protected]>
@iceseer
fixups
f5d5dca 
Signed-off-by: iceseer <[email protected]>
@iceseer
Revert "PATCH FOR APPROVAL"
906ce50 
This reverts commit 7bb1cfb.

Signed-off-by: iceseer <[email protected]>

# Conflicts:
#	core/parachain/approval/approval_distribution.cpp
@iceseer iceseer marked this pull request as ready for review September 28, 2024 13:28
@iceseer iceseer force-pushed the feature/fragment_chain branch 2 times, most recently from 3532e0c to a7dd40d Compare September 28, 2024 14:25
@iceseer
Merge remote-tracking branch 'origin/master' into feature/fragment_chain
5b14c9f 
Signed-off-by: iceseer <[email protected]>

# Conflicts:
#	core/parachain/validator/backing_implicit_view.cpp
#	core/parachain/validator/fragment_tree.hpp
#	core/parachain/validator/impl/parachain_processor.cpp
#	core/parachain/validator/parachain_processor.hpp
#	core/parachain/validator/prospective_parachains.hpp
#	core/parachain/validator/prospective_parachains/constraints.cpp
@iceseer iceseer force-pushed the feature/fragment_chain branch from a7dd40d to 5b14c9f Compare September 28, 2024 16:15
@iceseer iceseer force-pushed the feature/fragment_chain branch 3 times, most recently from ee9097e to e30a1ad Compare October 1, 2024 11:29
@iceseer
clang-tidy fixes
7d42520 
Signed-off-by: iceseer <[email protected]>
@iceseer iceseer force-pushed the feature/fragment_chain branch from e30a1ad to 7d42520 Compare October 1, 2024 12:14
@iceseer
Merge remote-tracking branch 'origin/master' into feature/fragment_chain
d8a3475 
Signed-off-by: iceseer <[email protected]>

# Conflicts:
#	core/network/impl/protocols/protocol_fetch_available_data.hpp
#	core/parachain/validator/impl/parachain_processor.cpp
#	test/core/parachain/grid.cpp
@iceseer iceseer force-pushed the feature/fragment_chain branch from 0719de4 to d8a3475 Compare October 2, 2024 15:20
igor-egorov
igor-egorov previously approved these changes Oct 3, 2024
View reviewed changes
Copy link
Contributor

@igor-egorov igor-egorov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks clean

@igor-egorov igor-egorov dismissed their stale review October 3, 2024 09:05

convert approve to a comment

@iceseer
fixup
4d331a2 
Signed-off-by: iceseer <[email protected]>
@iceseer iceseer enabled auto-merge (squash) October 6, 2024 21:27
@iceseer iceseer merged commit 6df4d6e into master Oct 7, 2024
13 checks passed
@iceseer iceseer deleted the feature/fragment_chain branch October 7, 2024 06:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@turuslan turuslan turuslan approved these changes

@igor-egorov igor-egorov igor-egorov approved these changes

@xDimon xDimon Awaiting requested review from xDimon

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@iceseer @turuslan @igor-egorov