Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor: remove rolling sessions window #2110

Merged
merged 17 commits into from
Jun 10, 2024

Conversation

xDimon
Copy link
Member

@xDimon xDimon commented May 22, 2024

Referenced issues

No specified

Description of the Change

Removes RollingSessionWindow.
Session data obtaining is based on runtime calls and cache now.

Possible Drawbacks

Checklist Before Opening a PR

Before you open a Pull Request (PR), please make sure you've completed the following steps and confirm by answering 'Yes' to each item:

  1. Code is formatted: Have you run your code through clang-format to ensure it adheres to the project's coding standards? No
  2. Code is documented: Have you added comments and documentation to your code according to the guidelines in the project's contributing guidelines? Yes (not affected)
  3. Self-review: Have you reviewed your own code to ensure it is free of typos, syntax errors, logical errors, and unresolved TODOs or FIXME without linking to an issue? Yes
  4. Zombienet Tests: Have you ensured that the zombienet tests are passing? Zombienet is a network simulation and testing tool used in this project. It's important to ensure that these tests pass to maintain the stability and reliability of the project. No (not affected)

xDimon added 5 commits May 22, 2024 14:25
Signed-off-by: Dmitriy Khaustov aka xDimon <[email protected]>
Signed-off-by: Dmitriy Khaustov aka xDimon <[email protected]>
Signed-off-by: Dmitriy Khaustov aka xDimon <[email protected]>
Signed-off-by: Dmitriy Khaustov aka xDimon <[email protected]>
@xDimon xDimon requested review from kamilsa and iceseer May 22, 2024 11:31
@xDimon xDimon requested a review from kamilsa May 28, 2024 11:25
@xDimon xDimon enabled auto-merge (squash) May 28, 2024 11:26
@xDimon xDimon merged commit c4ed311 into master Jun 10, 2024
12 of 14 checks passed
@xDimon xDimon deleted the test/without_rolling_sessions_window branch June 10, 2024 09:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants