Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce kagome-dev #2064

Merged
merged 3 commits into from
Apr 27, 2024
Merged

Reduce kagome-dev #2064

merged 3 commits into from
Apr 27, 2024

Conversation

kamilsa
Copy link
Contributor

@kamilsa kamilsa commented Apr 25, 2024

Referenced issues

None

Description of the Change

  • Removes redundant llvms from kagome-dev to reduce docker container size
  • Removes some outdated Soramitsu references
  • Fixes a typo in enhancement.yml

Possible Drawbacks

  • Some old llvms won't be available (but they aren't needed anyway)

Checklist Before Opening a PR

Before you open a Pull Request (PR), please make sure you've completed the following steps and confirm by answering 'Yes' to each item:

  1. Code is formatted: Have you run your code through clang-format to ensure it adheres to the project's coding standards? Yes
  2. Code is documented: Have you added comments and documentation to your code according to the guidelines in the project's contributing guidelines? Yes
  3. Self-review: Have you reviewed your own code to ensure it is free of typos, syntax errors, logical errors, and unresolved TODOs or FIXME without linking to an issue? Yes
  4. Zombienet Tests: Have you ensured that the zombienet tests are passing? Zombienet is a network simulation and testing tool used in this project. It's important to ensure that these tests pass to maintain the stability and reliability of the project. No

kamilsa added 2 commits April 25, 2024 12:14
* Also removes some outdated Soramitsu references
* Fixes type in enhancement.yml
@kamilsa kamilsa requested review from turuslan and zerg-su April 25, 2024 07:17
@kamilsa kamilsa changed the title enhancement/reduce-kagome-dev Reduce kagome-dev Apr 25, 2024
@kamilsa kamilsa enabled auto-merge (squash) April 27, 2024 02:10
@kamilsa kamilsa merged commit e185426 into master Apr 27, 2024
9 of 10 checks passed
@kamilsa kamilsa deleted the enhancement/reduce-kagome-dev branch April 27, 2024 02:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants