Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Host API fallback #1987

Merged
merged 13 commits into from
Feb 20, 2024
Merged

Host API fallback #1987

merged 13 commits into from
Feb 20, 2024

Conversation

Harrm
Copy link
Contributor

@Harrm Harrm commented Feb 14, 2024 •
edited
Loading

Referenced issues

closes #1889

Description of the Change

  • Make all runtime engines use the same macro with the list of host methods.
  • Don't fail a runtime module instantiation if some host methods are missing, only fail the runtime call when it tries to call a missing method

Benefits

  • Correct behaviour
  • Reduced code duplication

Possible Drawbacks

  • WAVM currently doesn't print a log message when a missing host method is called

@Harrm Harrm marked this pull request as ready for review February 15, 2024 15:54
@Harrm Harrm requested a review from iceseer February 16, 2024 09:04
@Harrm Harrm merged commit fadb610 into master Feb 20, 2024
12 of 13 checks passed
@Harrm Harrm deleted the feature/host-api-fallback branch February 20, 2024 16:34
iceseer pushed a commit that referenced this pull request Feb 23, 2024
@Harrm @iceseer
Host API fallback (#1987)
c163972 
* Host API uniformation

* Refactor WAVM host method registration

* Fix exception processing

* Fix clang-15 detection

Signed-off-by: iceseer <[email protected]>
# Conflicts:
#	core/network/impl/peer_manager_impl.cpp
#	core/parachain/validator/impl/parachain_processor.cpp
iceseer added a commit that referenced this pull request Feb 23, 2024
@iceseer
Revert "Host API fallback (#1987)"
b511de3 
This reverts commit c163972.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@turuslan turuslan turuslan approved these changes

@iceseer iceseer iceseer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Don't crash when unknown host api is observed
3 participants
@Harrm @turuslan @iceseer