Watchdog #1870
Merged
Watchdog #1870
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: turuslan <[email protected]>
Signed-off-by: Igor Egorov <[email protected]>
Signed-off-by: Igor Egorov <[email protected]>
Signed-off-by: Igor Egorov <[email protected]>
Signed-off-by: Igor Egorov <[email protected]>
Signed-off-by: Igor Egorov <[email protected]>
turuslan
approved these changes
Nov 17, 2023
xDimon
approved these changes
Nov 20, 2023
core/utils/watchdog.hpp
Outdated
| std::shared_ptr<Atomic> count_; | ||
|
|
||
| void operator()() { | ||
| ++*count_; |
There was a problem hiding this comment.
Suggested change
| ++*count_; | |
| count_->fetch_add(1); |
core/utils/watchdog.hpp
Outdated
| if (lag > timeout) { | ||
| std::stringstream s; | ||
| s << it->first; | ||
| fmt::print( |
There was a problem hiding this comment.
Let's use SL_CRITICAL. It flushes all collected buffers after add log message
core/utils/watchdog.hpp
Outdated
| void run(std::shared_ptr<boost::asio::io_context> io) { | ||
| auto ping = add(); | ||
| while (not stopped_ and not io.unique()) { | ||
| #if 0 |
There was a problem hiding this comment.
if constexpr (false) would be better - selective compilation with checking both branches.
There was a problem hiding this comment.
No, if constexpr (false) doesn't compile here (requires template).
std::chrono::seconds wait{1};
[&](auto &io) {
boost::system::error_code ec;
auto wait_us = std::chrono::duration_cast<std::chrono::microseconds>(wait);
if constexpr (requires { io->impl_.wait_one(wait_us.count(), ec); }) {
io->impl_.wait_one(wait_us.count(), ec);
ping();
io->poll_one();
} else {
io->run_one_for(wait);
}
}(io);
Signed-off-by: Igor Egorov <[email protected]>
Signed-off-by: Igor Egorov <[email protected]>
Signed-off-by: Igor Egorov <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Referenced issues
Description of the Change
An implementation of in-process watchdog based on timing out boost asio loops.
Default timeout is set to be 15 min.
Benefits
Not an over-complicated implementation.
Possible Drawbacks
The watchdog would not track the whole process state.