Fixes from review

core/application/impl/app_configuration_impl.cpp

@@ -13,12 +13,12 @@
 #include <rapidjson/document.h>
 #include <rapidjson/filereadstream.h>
 #include <boost/algorithm/string.hpp>
-#include "filesystem/common.hpp"
 #include <boost/program_options.hpp>
 #include <boost/uuid/uuid_generators.hpp>
 #include <boost/uuid/uuid_io.hpp>
 #include <charconv>
 #include <libp2p/layer/websocket/wss_adaptor.hpp>
+#include "filesystem/common.hpp"
 
 #include "api/transport/tuner.hpp"
 #include "application/build_version.hpp"
@@ -34,7 +34,7 @@ namespace {
 
   template <typename T, typename Func>
   void find_argument(boost::program_options::variables_map &vm,
-                     char const *name,
+                     const char *name,
                      Func &&f) {
     assert(nullptr != name);
     if (auto it = vm.find(name); it != vm.end()) {
@@ -225,7 +225,6 @@ namespace kagome::application {
         purge_wavm_cache_(def_purge_wavm_cache_),
         offchain_worker_mode_{def_offchain_worker_mode},
         enable_offchain_indexing_{def_enable_offchain_indexing},
-        subcommand_{},
         recovery_state_{def_block_to_recover} {
     SL_INFO(logger_, "Soramitsu Kagome started. Version: {} ", buildVersion());
   }
@@ -1368,7 +1367,8 @@ namespace kagome::application {
         return false;
       }
       benchmark_config_ = BlockBenchmarkConfig{
-          .from = *from_opt, .to = *to_opt, .times = *repeat_opt};
+          .from = *from_opt, .to = *to_opt, .times = *repeat_opt,
+      };
     }
 
     bool has_recovery = false;

core/benchmark/block_execution_benchmark.cpp

@@ -31,6 +31,8 @@ OUTCOME_CPP_DEFINE_CATEGORY(kagome::benchmark,
 
 static_assert(STR(CONCAT(2, 3)) == std::string_view("23"));
 
+// mind if you want to move it to global scope, __LINE__ is not very reliable,
+// may use __COUNTER__ instead
 #define OUTCOME_TRY_MSG(var, expr, msg, ...)              \
   auto CONCAT(_res_, __LINE__) = (expr);                  \
   do {                                                    \

core/network/impl/protocols/protocol_error.hpp

@@ -17,7 +17,7 @@ namespace kagome::network {
     NODE_NOT_SYNCHRONIZED_YET,
     GENESIS_NO_MATCH,
     HANDSHAKE_ERROR,
-    NO_RESPONSE
+    NO_RESPONSE,
   };
 
 }

core/storage/spaces.hpp

@@ -21,9 +21,6 @@ namespace kagome::storage {
     kJustification,
     kTrieNode,
 
-    kTriePruner,
-    kBlockData,
-
     //
     kTotal
   };

core/utils/benchmark_main.cpp

@@ -25,6 +25,7 @@ namespace kagome {
       SL_ERROR(config_logger, "Failed to initialize kagome!");
       return -1;
     }
+    kagome::log::tuneLoggingSystem(config->log());
 
     injector::KagomeNodeInjector injector{config};
 

core/utils/kagome_db_editor.cpp

@@ -225,11 +225,6 @@ int db_editor_main(int argc, const char **argv) {
     target_state_param = RootHash::fromHexWithPrefix(argv[2]).value();
   }
 
-  auto logging_system = std::make_shared<soralog::LoggingSystem>(
-      std::make_shared<Configurator>());
-  std::ignore = logging_system->configure();
-  log::setLoggingSystem(logging_system);
-
   auto log = log::createLogger("main", "kagome-db-editor");
 
   common::Buffer prefix{};

core/utils/storage_explorer.cpp

@@ -516,18 +516,6 @@ int storage_explorer_main(int argc, const char **argv) {
   CommandParser parser;
   parser.addCommand(std::make_unique<PrintHelpCommand>(parser));
 
-  auto logging_system = std::make_shared<soralog::LoggingSystem>(
-      std::make_shared<kagome::log::Configurator>(
-          std::make_shared<libp2p::log::Configurator>()));
-
-  auto r = logging_system->configure();
-  if (not r.message.empty()) {
-    (r.has_error ? std::cerr : std::cout) << r.message << std::endl;
-  }
-  if (r.has_error) {
-    exit(EXIT_FAILURE);
-  }
-  kagome::log::setLoggingSystem(logging_system);
   kagome::log::setLevelOfGroup("*", kagome::log::Level::WARN);
 
   auto logger = kagome::log::createLogger("AppConfiguration", "main");
@@ -553,7 +541,7 @@ int storage_explorer_main(int argc, const char **argv) {
   }
 
   kagome::injector::KagomeNodeInjector injector{configuration};
-  /*auto block_storage = injector.injectBlockStorage();
+  auto block_storage = injector.injectBlockStorage();
   auto trie_storage = injector.injectTrieStorage();
   auto app_state_manager = injector.injectAppStateManager();
   auto block_tree = injector.injectBlockTree();
@@ -585,7 +573,7 @@ int storage_explorer_main(int argc, const char **argv) {
   parser.addCommand(std::make_unique<SearchChainCommand>(
       block_storage, trie_storage, authority_manager, hasher));
 
-  parser.invoke(args.subspan(0, kagome_args_start));*/
+  parser.invoke(args.subspan(0, kagome_args_start));
 
   return 0;
 }