Skip parachains for syncing node. #1520
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iceseer
force-pushed
the
fix/skip_parachains
branch
2 times, most recently
from
b866859 to
303a13e
Compare
iceseer
force-pushed
the
fix/skip_parachains
branch
from
303a13e to
38cdd27
Compare
Signed-off-by: iceseer <[email protected]>
iceseer
force-pushed
the
fix/skip_parachains
branch
from
38cdd27 to
bc215dc
Compare
xDimon
approved these changes
Mar 11, 2023
| SL_WARN( | ||
| self->logger_, | ||
| "Broadcast my view failed, because my view still not exists."); | ||
| return; |
There was a problem hiding this comment.
Should we continue to wait view for broadcast it first time?
turuslan
reviewed
Mar 12, 2023
| @@ -1005,15 +1005,6 @@ namespace kagome::parachain { | |||
| void ApprovalDistribution::handle_new_head(const primitives::BlockHash &head, | |||
| const network::ExView &updated, | |||
| Func &&func) { | |||
| /*sequenceIgnore(this_context_->template wrap(asAsync( | |||
There was a problem hiding this comment.
Remove or uncomment.
Also clang-format, or move this block to lambda variable (to avoid re-formatting)
turuslan
approved these changes
Mar 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Change
Skip parachains handling either syncing node or in synchronization state.