Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix runtime api #1464

Merged
merged 5 commits into from
Jan 11, 2023
Merged

Fix runtime api #1464

merged 5 commits into from
Jan 11, 2023

Conversation

turuslan
Copy link
Contributor

@turuslan turuslan commented Jan 9, 2023

Referenced issues

Description of the Change

  • Don't commit intermediate state trie between calls.
    • Commit state trie only when requested from BlockBuilder_finalize_block.

Benefits

  • Correct state trie hash when producing blocks.

Possible Drawbacks

@turuslan turuslan requested review from xDimon and Harrm January 9, 2023 14:20
@turuslan turuslan merged commit 20d48f3 into master Jan 11, 2023
@turuslan turuslan deleted the fix/runtime-api branch January 11, 2023 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xDimon xDimon xDimon approved these changes

@Harrm Harrm Harrm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@turuslan @xDimon @Harrm