Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Trie version 1 #1433

Merged
merged 41 commits into from
Jan 13, 2023
Merged

Trie version 1 #1433

merged 41 commits into from
Jan 13, 2023

Conversation

turuslan
Copy link
Contributor

@turuslan turuslan commented Dec 2, 2022 •
edited
Loading

Referenced issues

Description of the Change

  • Trie version 1 (hashed values)
  • Simplify trie nodes
  • Fix hashed value encoding
  • Get/set with hashed value
  • Add version parameter to usages

Benefits

  • Can sync rococo after 2848657

Possible Drawbacks

  • Testing (with rococo blocks) didn't cover all cases (e.g. child storage, block production, trie restructuring).
  • Didn't add "read from db" dependency, reused DummyNode - struct DummyValue.

@turuslan turuslan requested review from kamilsa and Harrm December 2, 2022 12:39
kamilsa
kamilsa approved these changes Dec 19, 2022
View reviewed changes
Copy link
Contributor

@kamilsa kamilsa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add task to remove StateVersion::TODO_NotSpecified when tests will cover it

@turuslan turuslan requested a review from kamilsa December 22, 2022 14:25
@turuslan
explicit v0
dcad971 
Signed-off-by: turuslan <[email protected]>
@turuslan
blob constexpr
516ace0 
Signed-off-by: turuslan <[email protected]>
@turuslan
trie empty root hash
0cbdc9a 
Signed-off-by: turuslan <[email protected]>
@turuslan
unused warning
f6baba8 
Signed-off-by: turuslan <[email protected]>
@turuslan
Merge remote-tracking branch 'origin/master' into rococo/2848657
f5ee6bb
@turuslan
Merge remote-tracking branch 'origin/master' into rococo/2848657
01cf60b 
Signed-off-by: turuslan <[email protected]>
@turuslan
Merge branch 'k1' into rococo/2848657
15f5988
@turuslan
fast sync
8f769fd 
Signed-off-by: turuslan <[email protected]>
@turuslan
genesis
1fd81fc 
Signed-off-by: turuslan <[email protected]>
@turuslan
fix argc
e5c7ba7 
Signed-off-by: turuslan <[email protected]>
@turuslan
deduplicate code instantiation
d1eeb0e 
Signed-off-by: turuslan <[email protected]>
@turuslan
Merge branch 'master' into rococo/2848657
55ed2ef 
Signed-off-by: turuslan <[email protected]>
@turuslan
ext child storage
e35146e 
Signed-off-by: turuslan <[email protected]>
@turuslan
Merge remote-tracking branch 'origin/master' into r
6291e6e 
Signed-off-by: turuslan <[email protected]>
@turuslan
fix db editor
d469b3d 
Signed-off-by: turuslan <[email protected]>
Harrm
Harrm reviewed Jan 13, 2023
View reviewed changes
@turuslan
pr comment
26cac0c 
Signed-off-by: turuslan <[email protected]>
@turuslan
pr comment
ac57c20 
Signed-off-by: turuslan <[email protected]>
@turuslan turuslan merged commit 85e4e28 into master Jan 13, 2023
@turuslan turuslan deleted the rococo/2848657 branch January 13, 2023 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kamilsa kamilsa kamilsa approved these changes

@Harrm Harrm Harrm approved these changes

@igor-egorov igor-egorov igor-egorov approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@turuslan @kamilsa @Harrm @igor-egorov