Feature: core version and metadata cache #1391
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xDimon
force-pushed
the
feature/core_version_cache
branch
2 times, most recently
from
5bda630 to
2958405
Compare
Codecov Report
@@ Coverage Diff @@
## master #1391 +/- ##
=======================================
Coverage 24.44% 24.45%
=======================================
Files 633 638 +5
Lines 24035 24084 +49
Branches 12470 12492 +22
=======================================
+ Hits 5875 5889 +14
- Misses 12904 12938 +34
- Partials 5256 5257 +1
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
xDimon
force-pushed
the
feature/core_version_cache
branch
4 times, most recently
from
e7c760e to
09fe339
Compare
Signed-off-by: Dmitriy Khaustov aka xDimon <[email protected]>
Signed-off-by: Dmitriy Khaustov aka xDimon <[email protected]>
Signed-off-by: Dmitriy Khaustov aka xDimon <[email protected]>
Signed-off-by: Dmitriy Khaustov aka xDimon <[email protected]>
Signed-off-by: Dmitriy Khaustov aka xDimon <[email protected]>
Signed-off-by: Dmitriy Khaustov aka xDimon <[email protected]>
xDimon
force-pushed
the
feature/core_version_cache
branch
from
09fe339 to
efb26c8
Compare
igor-egorov
approved these changes
Nov 10, 2022
Signed-off-by: Dmitriy Khaustov aka xDimon <[email protected]>
Signed-off-by: Dmitriy Khaustov aka xDimon <[email protected]>
Signed-off-by: Dmitriy Khaustov aka xDimon <[email protected]>
Signed-off-by: Dmitriy Khaustov aka xDimon <[email protected]>
Signed-off-by: Dmitriy Khaustov aka xDimon <[email protected]>
turuslan
approved these changes
Nov 11, 2022
Signed-off-by: Dmitriy Khaustov aka xDimon <[email protected]>
Signed-off-by: Dmitriy Khaustov aka xDimon <[email protected]>
kamilsa
reviewed
Nov 14, 2022
| : env_{std::move(env)}, | ||
| rei_{std::move(rei)}, | ||
| parent_{std::move(parent)}, | ||
| code_hash_(code_hash), |
There was a problem hiding this comment.
hm, is this new field is even used in this class?
| RuntimePropertiesCacheImpl() = default; | ||
|
|
||
| outcome::result<primitives::Version> getVersion( | ||
| const common::Hash256 &hash, |
There was a problem hiding this comment.
it could be either hash of block or hash of state, please give this variable more meaningful name
| override; | ||
|
|
||
| outcome::result<primitives::OpaqueMetadata> getMetadata( | ||
| const common::Hash256 &hash, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Referenced issues
Resolves #1374
Description of the Change
Cache by code hash for calls "Core_version" and "Metadata_metadata"
Benefits
Avoid runtime using for some idempotent calls
Usage Examples or Tests
Existing tests adapted