Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove LevelDb from dependencies #1380

Merged
merged 2 commits into from
Oct 28, 2022
Merged

Remove LevelDb from dependencies #1380

merged 2 commits into from
Oct 28, 2022

Conversation

Harrm
Copy link
Contributor

@Harrm Harrm commented Oct 28, 2022

Referenced issues

Description of the Change

LevelDb dependencies are removed from kagome code, but LevelDb is still in Hunter dependencies.

Benefits

Faster build.

Possible Drawbacks

None expected.

@Harrm Harrm marked this pull request as ready for review October 28, 2022 12:29
@Harrm Harrm enabled auto-merge (squash) October 28, 2022 12:30
@codecov
Copy link

codecov bot commented Oct 28, 2022

Codecov Report

Merging #1380 (d259d91) into master (db19edf) will decrease coverage by 0.00%.
The diff coverage is 0.00%.

❗ Current head d259d91 differs from pull request most recent head 04d8b5c. Consider uploading reports for the commit 04d8b5c to get more accurate results

@@            Coverage Diff             @@
##           master    #1380      +/-   ##
==========================================
- Coverage   24.58%   24.58%   -0.01%     
==========================================
  Files         629      629              
  Lines       23613    23613              
  Branches    12288    12288              
==========================================
- Hits         5806     5805       -1     
  Misses      12540    12540              
- Partials     5267     5268       +1     
Impacted Files Coverage Δ
core/storage/in_memory/in_memory_storage.hpp 100.00% <ø> (ø)
core/storage/rocksdb/rocksdb_util.hpp 52.38% <0.00%> (ø)
core/api/transport/impl/ws/ws_listener_impl.cpp 41.66% <0.00%> (-1.39%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@Harrm Harrm merged commit 10b8811 into master Oct 28, 2022
@Harrm Harrm deleted the fix/remove-ldb-hunter branch October 28, 2022 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants