OnPeerDisconnected handler. #1369
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: iceseer <[email protected]>
iceseer
force-pushed
the
fix/on_peer_disconnected_event_handling
branch
from
e4cf623 to
fdd80d2
Compare
Codecov Report
@@ Coverage Diff @@
## master #1369 +/- ##
=======================================
Coverage 24.15% 24.15%
=======================================
Files 627 627
Lines 23464 23459 -5
Branches 12267 12262 -5
=======================================
Hits 5667 5667
+ Misses 12522 12517 -5
Partials 5275 5275
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Signed-off-by: iceseer <[email protected]>
Signed-off-by: iceseer <[email protected]>
kamilsa
approved these changes
Oct 14, 2022
Signed-off-by: iceseer <[email protected]>
Signed-off-by: iceseer <[email protected]>
Signed-off-by: iceseer <[email protected]>
iceseer
force-pushed
the
fix/on_peer_disconnected_event_handling
branch
from
44f3a06 to
99de27b
Compare
xDimon
reviewed
Oct 18, 2022
Signed-off-by: iceseer <[email protected]>
xDimon
approved these changes
Oct 18, 2022
|
Я вернул проверку на существование в active_peers_ перед удалением, т.е. теперь удалится только если перешел из connecting_peers_ в active_peers_. Но имхо теперь есть неоднозначность и возможная неконсистентность с состоянием в libp2p. Мы вызвали удаление и libp2p все почистил, вызвал колбэк, а мы не удалили. Выглядит как будто у нас была ошибка раньше |
This reverts commit 856cbb6.
Signed-off-by: iceseer <[email protected]>
xDimon
approved these changes
Oct 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: iceseer [email protected]
Description of the Change
OnPeerDisconnected event handling. Revove our current states by this event.